@W-20892577 Save phone number during user registration of BOPIS orders#3577
Closed
syadupathi-sf wants to merge 1 commit intofeature/1cc_mergefrom
Closed
@W-20892577 Save phone number during user registration of BOPIS orders#3577syadupathi-sf wants to merge 1 commit intofeature/1cc_mergefrom
syadupathi-sf wants to merge 1 commit intofeature/1cc_mergefrom
Conversation
syadupathi-sf
added
the
skip changelog
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| // Persist phone number as phoneHome for all order types (delivery and pickup) | ||
| // Try billing address phone first, then fall back to contact phone from context | ||
| const phoneHome = | ||
| order?.billingAddress?.phone || |
Contributor
There was a problem hiding this comment.
Oh interesting - we actually trying to extract phone number from the billing address?? So that means the field is required (?) I'd assume we should rely on the one filled out at the Contact Info stage..
Also wondering why this does not work for BOPIS (even though there is a phone number field on billing address form for BOPIS orders)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checkout as guest, do in store pick up, register account.
Full name shows name (or email if that is decided behavior), and phone number should show phone. It doesn't save phone number currently.
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization