-
Notifications
You must be signed in to change notification settings - Fork 214
@W-20784722@ Move envBasePath into ssrParameters #3590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
e30be6e
cb45ac9
c72bd6d
cbb8838
c7ee6bb
3282144
33ce533
50d5331
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,7 +84,6 @@ module.exports = { | |
| apiKey: process.env.GOOGLE_CLOUD_API_KEY | ||
| } | ||
| }, | ||
| envBasePath: '/', | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need the same default value in ssrParameters?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No. The default value is for the envBasePath to be undefined so that it is not set on MRT or local. Once it is defined, it must be a valid value (ie. /shop). The changes in this PR disallow setting envBasePath to just |
||
| externals: [], | ||
| pageNotFoundURL: '/page-not-found', | ||
| ssrEnabled: true, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a comment describing why we need to read from ssrParameters only for local development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment added