@W-21038080: Rework to use billing address phone number for guest shoppers#3618
Merged
dannyphan2000 merged 2 commits intofeature/1cc_mergefrom Jan 28, 2026
Merged
Conversation
…ppers Signed-off-by: d.phan <d.phan@salesforce.com>
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
dannyphan2000
commented
Jan 28, 2026
| } | ||
| } | ||
|
|
||
| const onBillingSubmit = async () => { |
Contributor
Author
There was a problem hiding this comment.
This is a fix for redundancy (we have this method in 2 different places, one-click-payment AND index.jsx - main entry code)
syadupathi-sf
approved these changes
Jan 28, 2026
syadupathi-sf
pushed a commit
that referenced
this pull request
Jan 29, 2026
…ppers (#3618) Signed-off-by: d.phan <d.phan@salesforce.com>
syadupathi-sf
pushed a commit
that referenced
this pull request
Jan 29, 2026
…ppers (#3618) Signed-off-by: d.phan <d.phan@salesforce.com>
syadupathi-sf
added a commit
that referenced
this pull request
Feb 2, 2026
* One click checkout * changes to fix install, tests and lint - needs to be reviewed * Change log * revert the test change in pwa-kit-runtime * Change commerce-sdk-react package-lock in an attempt to get the CI working * Increase bundle size of template-retail-react-app by 1KB * @W-20542850 Remove promotion from Shipping Method summary view (#3563) * W-20542850 Remove promotion from Shipping Method summary view * add translations * W-19728108 Add amount to payment instrument in the basket (#3568) * W-19728108 Amount for the registered shopper (#3572) * W-20892453 Remove store pickup shipping option (#3575) * @W-20892497 Show Phone number in Contact Info summary (#3576) * W-20892497 Show Phone number in Contact Info summary * fix lint * @W-20892554 Show spinner when user registration checkbox is clicked (#3578) * W-20892554 Show spinner when user registration checkbox is clicked * add test * @W-20892592 Remove gift messaging for multi shipment (#3579) * W-20892592 Remove gift messaging for multi shipment * translations * @W-20892530 @W-20892577 Billing Address Validation and Using contact phone for user registration (#3583) * W-20892530 Billing Address Validation * W-20892577 save contact info phone * @W-20931438 Add spinner for place order button (#3587) * Add spinner for place order button * skip changelog * Update isomorphic version to the newly released version (#3592) * Fix SDK tests (#3593) * fix sdk tests and app bundle size * fix lint * @W-20931758 Allow guest shopper to change payment (#3591) * W-20931758 Allow guest shopper to change payment after applying it * changed the error code to use an existing one * @W-21000333: [BOPIS] Should skip pick up address (#3601) Signed-off-by: d.phan <d.phan@salesforce.com> * W-21005962 Disable user registration when billing address is not valid (#3605) * @W-21000338: [BOPIS] Auto-populate billing address with default address (#3602) Signed-off-by: d.phan <d.phan@salesforce.com> * @W-21006290: [BOPIS] Continue to Shipping Address label fix for BOPIS-only orders (#3604) * @W-21006290: [BOPIS] Continue to Shipping Address label fix for BOPIS-only orders Signed-off-by: d.phan <d.phan@salesforce.com> * add translations Signed-off-by: d.phan <d.phan@salesforce.com> * fix lint Signed-off-by: d.phan <d.phan@salesforce.com> * fix utest Signed-off-by: d.phan <d.phan@salesforce.com> --------- Signed-off-by: d.phan <d.phan@salesforce.com> * @W-21000344: [BOPIS] Pickup address component enhancement (#3607) Signed-off-by: d.phan <d.phan@salesforce.com> * W-21005976 Newly registered user can change payment (#3608) * @W-21038080: [1CC][PWA] Add new feature toggle in config to template files (#3609) * @W-21038080: [1CC][PWA] Add new feature toggle in config to template files Signed-off-by: d.phan <d.phan@salesforce.com> * add new changelog Signed-off-by: d.phan <d.phan@salesforce.com> --------- Signed-off-by: d.phan <d.phan@salesforce.com> * @W-21038080: Rework to use billing address phone number for guest shoppers (#3618) Signed-off-by: d.phan <d.phan@salesforce.com> * @ W-20540715 Address 1CC feature branch review comments (#3619) * address first set of comments * address rest of code review comments * reverting default.js changes * fix package versions * shipping options fix * attempt to fix flaky tests * test * passwordless mode updates * fix unit test * @W-20892603: Remove empty shipment fix (#3622) * @W-20892603: empty shipment fix Signed-off-by: d.phan <d.phan@salesforce.com> * trigger ci Signed-off-by: d.phan <d.phan@salesforce.com> --------- Signed-off-by: d.phan <d.phan@salesforce.com> * Update packages/template-retail-react-app/app/pages/checkout-one-click/partials/one-click-contact-info.jsx Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com> Signed-off-by: syadupathi-sf <66088780+syadupathi-sf@users.noreply.github.com> * revert to generic error message as per code review comment * activity event tracking for 1cc (#3627) * test failure (#3629) --------- Signed-off-by: d.phan <d.phan@salesforce.com> Signed-off-by: syadupathi-sf <66088780+syadupathi-sf@users.noreply.github.com> Co-authored-by: Danny Phan <125327707+dannyphan2000@users.noreply.github.com> Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com> Co-authored-by: kumaravinashcommercecloud <kumaravinash@salesforce.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in BOPIS, or when we switch BOPIS -> Ship (Guest shopper). Phone number does not get persisted if we leave Checkout and come back for guest shoppers.
Result: Phone number field (in Contact Info) is not showing in Summary view. When trying to hit Edit, I do see that field populated, but when I hit continue, it's not there...
Expected: Phone number field should be visible in Contact Info summary view if filled out
Using
basket.billingAddress.phoneto store guest shopper’s phone number.We use billing phone temporarily in the guest basket just to get around the issue of going back and forth from checkout to cart or elsewhere. Then update new customer profile with billing address phone. But don’t update order with billing phone because from a shopper’s perspective, they are entering their contact number and not the billing phone number.
Description
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization