@W-21109850: Continue as Guest skips entering phone number by dannyphan2000 · Pull Request #3626 · SalesforceCommerceCloud/pwa-kit

dannyphan2000 · 2026-01-30T20:25:59Z

Enter checkout as a guest. Fill out a registered email address, but choose to Continue as Guest.

Result: The modal is closed. But we're skipping Contact Information stage without needing to fill out phone number (required field).
Expected: The modal should be closed, but stay in Contact Information stage so that shopper can enter their phone number. We allow shoppers to enter information manually (like a guest shopper).

Description

Types of Changes

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Documentation update
Breaking change (could cause existing functionality to not work as expected)
Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop

Adding a required argument to a function

Changing the data type of a function parameter or return value

Adding a new peer dependency to package.json

Changes

How to Test-Drive This PR

See desciption

Checklists

General

Changes are covered by test cases
CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

There are no changes to UI

or...

Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
Changes comply with WCAG 2.0 guidelines levels A and AA
Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

Changes include a UI text update in the Retail React App (which requires translation)

cc-prodsec · 2026-01-30T20:26:12Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

dannyphan2000 · 2026-01-30T20:28:29Z

...s/template-retail-react-app/app/pages/checkout-one-click/partials/one-click-contact-info.jsx

-        } catch (error) {
-            const message = formatMessage(getPasswordlessErrorMessage(error.message))
-            setError(message)
+    const handleCheckoutAsGuest = () => {


Only closing the modal for now (and set state)

dannyphan2000 · 2026-01-30T20:28:57Z

...s/template-retail-react-app/app/pages/checkout-one-click/partials/one-click-contact-info.jsx

            }

-            if (!result.isRegistered) {
+            if (!result.isRegistered || registeredUserChoseGuest) {


All the information are saved to basket upon Continue to Shipping Address (ie submit the form) just like a guest shopper

* W-20892497 Show Phone number in Contact Info summary * fix lint

* W-20892592 Remove gift messaging for multi shipment * translations

…phone for user registration (#3583) * W-20892530 Billing Address Validation * W-20892577 save contact info phone

* fix sdk tests and app bundle size * fix lint

* address first set of comments * address rest of code review comments * reverting default.js changes * fix package versions * shipping options fix * attempt to fix flaky tests

Signed-off-by: d.phan <d.phan@salesforce.com>

* @W-21109850: Continue as Guest skips entering phone number (#3626) * One click checkout * changes to fix install, tests and lint - needs to be reviewed * revert the test change in pwa-kit-runtime * @W-20892497 Show Phone number in Contact Info summary (#3576) * W-20892497 Show Phone number in Contact Info summary * fix lint * @W-20892592 Remove gift messaging for multi shipment (#3579) * W-20892592 Remove gift messaging for multi shipment * translations * @W-20892530 @W-20892577 Billing Address Validation and Using contact phone for user registration (#3583) * W-20892530 Billing Address Validation * W-20892577 save contact info phone * Fix SDK tests (#3593) * fix sdk tests and app bundle size * fix lint * @ W-20540715 Address 1CC feature branch review comments (#3619) * address first set of comments * address rest of code review comments * reverting default.js changes * fix package versions * shipping options fix * attempt to fix flaky tests * passwordless mode updates * @W-21109850: Continue as Guest skips entering phone number Signed-off-by: d.phan <d.phan@salesforce.com> * fix import Signed-off-by: d.phan <d.phan@salesforce.com> * translations * fix user not found error --------- Signed-off-by: d.phan <d.phan@salesforce.com> Co-authored-by: Sushma Yadupathi <syadupathi@salesforce.com> Co-authored-by: syadupathi-sf <66088780+syadupathi-sf@users.noreply.github.com> * W-21111863 Hide user registration for returning shoppers who chose to checkout as guest (#3634) * @W-21005976 Save newly registered user's info when they leave checkout… (#3632) * W-21005976 Save newly registered user's info when they leave checkout and return * code review comments * @W-21109829 Editing shipping options in multi shipment scenarios (#3637) * W-21109829 Editing shipping options in multi shipment scenarios * minor text changes * remove unnecessary test --------- Signed-off-by: d.phan <d.phan@salesforce.com> Signed-off-by: syadupathi-sf <66088780+syadupathi-sf@users.noreply.github.com> Co-authored-by: Danny Phan <125327707+dannyphan2000@users.noreply.github.com>

dannyphan2000 requested a review from a team as a code owner January 30, 2026 20:25

dannyphan2000 added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Jan 30, 2026

dannyphan2000 requested a review from syadupathi-sf January 30, 2026 20:28

dannyphan2000 commented Jan 30, 2026

View reviewed changes

Base automatically changed from feature/1cc_merge to develop February 2, 2026 18:10

syadupathi-sf requested a review from a team as a code owner February 2, 2026 18:10

syadupathi-sf and others added 11 commits February 2, 2026 18:12

One click checkout

e116bc2

changes to fix install, tests and lint - needs to be reviewed

bb0eab8

revert the test change in pwa-kit-runtime

a7c1d94

@W-20892497 Show Phone number in Contact Info summary (#3576)

56bb9a4

* W-20892497 Show Phone number in Contact Info summary * fix lint

@W-20892592 Remove gift messaging for multi shipment (#3579)

96af92e

* W-20892592 Remove gift messaging for multi shipment * translations

@W-20892530 @W-20892577 Billing Address Validation and Using contact …

96364ae

…phone for user registration (#3583) * W-20892530 Billing Address Validation * W-20892577 save contact info phone

Fix SDK tests (#3593)

eeb198e

* fix sdk tests and app bundle size * fix lint

@ W-20540715 Address 1CC feature branch review comments (#3619)

131eb6c

* address first set of comments * address rest of code review comments * reverting default.js changes * fix package versions * shipping options fix * attempt to fix flaky tests

passwordless mode updates

35f2265

@W-21109850: Continue as Guest skips entering phone number

f7faf3d

Signed-off-by: d.phan <d.phan@salesforce.com>

fix import

bbf8ec8

Signed-off-by: d.phan <d.phan@salesforce.com>

syadupathi-sf force-pushed the dannyphan2000.W-21109850.continue-as-guest-fix branch from 83f32b6 to bbf8ec8 Compare February 2, 2026 23:19

syadupathi-sf added 2 commits February 2, 2026 18:48

translations

b63ed11

fix user not found error

ec3294f

syadupathi-sf approved these changes Feb 3, 2026

View reviewed changes

syadupathi-sf changed the base branch from develop to 1cc_bugs February 3, 2026 00:30

syadupathi-sf merged commit f867e6a into 1cc_bugs Feb 3, 2026
42 checks passed

syadupathi-sf deleted the dannyphan2000.W-21109850.continue-as-guest-fix branch February 3, 2026 00:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

@W-21109850: Continue as Guest skips entering phone number#3626

@W-21109850: Continue as Guest skips entering phone number#3626
syadupathi-sf merged 13 commits into1cc_bugsfrom
dannyphan2000.W-21109850.continue-as-guest-fix

dannyphan2000 commented Jan 30, 2026 •

edited by syadupathi-sf

Loading

Uh oh!

cc-prodsec commented Jan 30, 2026 •

edited

Loading

Uh oh!

dannyphan2000 Jan 30, 2026

Uh oh!

dannyphan2000 Jan 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dannyphan2000 commented Jan 30, 2026 • edited by syadupathi-sf Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of Changes

Changes

How to Test-Drive This PR

Checklists

General

Accessibility Compliance

Localization

Uh oh!

cc-prodsec commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

dannyphan2000 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

dannyphan2000 Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dannyphan2000 commented Jan 30, 2026 •

edited by syadupathi-sf

Loading

cc-prodsec commented Jan 30, 2026 •

edited

Loading

dannyphan2000 Jan 30, 2026 •

edited

Loading