Skip to content

@W-21086834: Use einstein.test.js test failure#3629

Merged
kumaravinashcommercecloud merged 1 commit intofeature/1cc_mergefrom
use-einstein.test.jsTestFailure
Jan 31, 2026
Merged

@W-21086834: Use einstein.test.js test failure#3629
kumaravinashcommercecloud merged 1 commit intofeature/1cc_mergefrom
use-einstein.test.jsTestFailure

Conversation

@kumaravinashcommercecloud
Copy link
Contributor

@kumaravinashcommercecloud kumaravinashcommercecloud commented Jan 31, 2026 •
edited
Loading

sendBeginCheckout and sendCheckoutStep now send a default checkoutType: 'traditional' in the request body. The tests were still asserting the old body without checkoutType, so they failed.

Description

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@kumaravinashcommercecloud kumaravinashcommercecloud added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Jan 31, 2026
@kumaravinashcommercecloud kumaravinashcommercecloud requested a review from a team as a code owner January 31, 2026 01:24
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Jan 31, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@kumaravinashcommercecloud kumaravinashcommercecloud merged commit 1eb4f7b into feature/1cc_merge Jan 31, 2026
42 checks passed
@kumaravinashcommercecloud kumaravinashcommercecloud deleted the use-einstein.test.jsTestFailure branch January 31, 2026 02:56
syadupathi-sf added a commit that referenced this pull request Feb 2, 2026
@syadupathi-sf @dannyphan2000
@hajinsuha1 @kumaravinashcommercecloud
@W-20540715 MERGE 1CC TO DEVELOP (#3552)
3533930 
* One click checkout

* changes to fix install, tests and lint - needs to be reviewed

* Change log

* revert the test change in pwa-kit-runtime

* Change commerce-sdk-react package-lock in an attempt to get the CI working

* Increase bundle size of template-retail-react-app by 1KB

* @W-20542850 Remove promotion from Shipping Method summary view (#3563)

* W-20542850 Remove promotion from Shipping Method summary view

* add translations

* W-19728108 Add amount to payment instrument in the basket (#3568)

* W-19728108 Amount for the registered shopper (#3572)

* W-20892453 Remove store pickup shipping option (#3575)

* @W-20892497 Show Phone number in Contact Info summary (#3576)

* W-20892497 Show Phone number in Contact Info summary

* fix lint

* @W-20892554 Show spinner when user registration checkbox is clicked (#3578)

* W-20892554 Show spinner when user registration checkbox is clicked

* add test

* @W-20892592 Remove gift messaging for multi shipment (#3579)

* W-20892592 Remove gift messaging for multi shipment

* translations

* @W-20892530 @W-20892577 Billing Address Validation and Using contact phone for user registration (#3583)

* W-20892530 Billing Address Validation

* W-20892577 save contact info phone

* @W-20931438 Add spinner for place order button (#3587)

* Add spinner for place order button

* skip changelog

* Update isomorphic version to the newly released version (#3592)

* Fix SDK tests (#3593)

* fix sdk tests and app bundle size

* fix lint

* @W-20931758 Allow guest shopper to change payment (#3591)

* W-20931758 Allow guest shopper to change payment after applying it

* changed the error code to use an existing one

* @W-21000333: [BOPIS] Should skip pick up address (#3601)

Signed-off-by: d.phan <d.phan@salesforce.com>

* W-21005962 Disable user registration when billing address is not valid (#3605)

* @W-21000338: [BOPIS] Auto-populate billing address with default address (#3602)

Signed-off-by: d.phan <d.phan@salesforce.com>

* @W-21006290: [BOPIS] Continue to Shipping Address label fix for BOPIS-only orders (#3604)

* @W-21006290: [BOPIS] Continue to Shipping Address label fix for BOPIS-only orders

Signed-off-by: d.phan <d.phan@salesforce.com>

* add translations

Signed-off-by: d.phan <d.phan@salesforce.com>

* fix lint

Signed-off-by: d.phan <d.phan@salesforce.com>

* fix utest

Signed-off-by: d.phan <d.phan@salesforce.com>

---------

Signed-off-by: d.phan <d.phan@salesforce.com>

* @W-21000344: [BOPIS] Pickup address component enhancement (#3607)

Signed-off-by: d.phan <d.phan@salesforce.com>

* W-21005976 Newly registered user can change payment (#3608)

* @W-21038080: [1CC][PWA] Add new feature toggle in config to template files (#3609)

* @W-21038080: [1CC][PWA] Add new feature toggle in config to template files

Signed-off-by: d.phan <d.phan@salesforce.com>

* add new changelog

Signed-off-by: d.phan <d.phan@salesforce.com>

---------

Signed-off-by: d.phan <d.phan@salesforce.com>

* @W-21038080: Rework to use billing address phone number for guest shoppers (#3618)

Signed-off-by: d.phan <d.phan@salesforce.com>

* @ W-20540715 Address 1CC feature branch review comments (#3619)

* address first set of comments

* address rest of code review comments

* reverting default.js changes

* fix package versions

* shipping options fix

* attempt to fix flaky tests

* test

* passwordless mode updates

* fix unit test

* @W-20892603: Remove empty shipment fix (#3622)

* @W-20892603: empty shipment fix

Signed-off-by: d.phan <d.phan@salesforce.com>

* trigger ci

Signed-off-by: d.phan <d.phan@salesforce.com>

---------

Signed-off-by: d.phan <d.phan@salesforce.com>

* Update packages/template-retail-react-app/app/pages/checkout-one-click/partials/one-click-contact-info.jsx

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Signed-off-by: syadupathi-sf <66088780+syadupathi-sf@users.noreply.github.com>

* revert to generic error message as per code review comment

* activity event tracking for 1cc (#3627)

* test failure (#3629)

---------

Signed-off-by: d.phan <d.phan@salesforce.com>
Signed-off-by: syadupathi-sf <66088780+syadupathi-sf@users.noreply.github.com>
Co-authored-by: Danny Phan <125327707+dannyphan2000@users.noreply.github.com>
Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: kumaravinashcommercecloud <kumaravinash@salesforce.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@syadupathi-sf syadupathi-sf syadupathi-sf approved these changes

Assignees

No one assigned

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kumaravinashcommercecloud @cc-prodsec @syadupathi-sf