Passwordless Login - Util function for passwordless callback URI#3630
Merged
vcua-mobify merged 6 commits intodevelopfrom Feb 3, 2026
Merged
Passwordless Login - Util function for passwordless callback URI#3630vcua-mobify merged 6 commits intodevelopfrom
vcua-mobify merged 6 commits intodevelopfrom
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
vcua-mobify
changed the title
alexvuong
previously approved these changes
Feb 2, 2026
alexvuong
approved these changes
Feb 3, 2026
hajinsuha1
approved these changes
Feb 3, 2026
Collaborator
hajinsuha1
left a comment
hajinsuha1
left a comment
There was a problem hiding this comment.
thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #3525 that reverts the changes made to the existing
absoluteUrlfunction in @salesforce/retail-react-app/app/utils/url in favor of a new util function that specifically returns the absolute url for the passwordless login callback, including base paths.The reason for this change is that we would like to keep the existing
absoluteUrlfunction as something that can work for both express routes (where a base path will always be added if it is set) and react router routes (where a base path may or may not be set).