Skip to content

@W-21005976 Save newly registered user's info when they leave checkout…#3632

Merged
syadupathi-sf merged 2 commits into1cc_bugsfrom
syadupathi.W-21005976.saveRegUserInfo
Feb 4, 2026
Merged

@W-21005976 Save newly registered user's info when they leave checkout…#3632
syadupathi-sf merged 2 commits into1cc_bugsfrom
syadupathi.W-21005976.saveRegUserInfo

Conversation

@syadupathi-sf
Copy link
Collaborator

@syadupathi-sf syadupathi-sf commented Feb 3, 2026

… and return

Description

Missing saved phone number, address and payment as newly registered user who leaves checkout and returns

  • Checkout as a guest shopper
  • Register account
  • Do not place order
  • Go back to Cart
  • Go back to Checkout (now as registered shopper)
  • Click Place Order.

Result: No saved phone number and address

Expected: Phone number and shipping address should be saved to the customer profile

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • see desc

How to Test-Drive This PR

  • see desc

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@syadupathi-sf syadupathi-sf requested a review from a team as a code owner February 3, 2026 20:48
@syadupathi-sf syadupathi-sf added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Feb 3, 2026
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Feb 3, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

kumaravinashcommercecloud
kumaravinashcommercecloud reviewed Feb 4, 2026
View reviewed changes
packages/template-retail-react-app/app/pages/checkout-one-click/partials/one-click-payment.jsx Outdated

// When a newly registered shopper leaves checkout and returns, they have no saved payments yet.
// Auto-check "Save for future use" so the next card they enter gets saved to their profile.
const hasAutoCheckedSaveForNewlyRegisteredRef = useRef(false)
Copy link
Contributor

@kumaravinashcommercecloud kumaravinashcommercecloud Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so when this checkbox is auto checked, and say the user unchecks it and goes back to cart, would this get enabled again when the user comes back to checkout?

kumaravinashcommercecloud
kumaravinashcommercecloud reviewed Feb 4, 2026
View reviewed changes
packages/template-retail-react-app/app/pages/checkout-one-click/partials/one-click-payment.jsx Outdated
useEffect(() => {
if (hasAutoCheckedSaveForNewlyRegisteredRef.current) return
if (!customer?.isRegistered) return
const hasNoSavedPayments =
Copy link
Contributor

@kumaravinashcommercecloud kumaravinashcommercecloud Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would apply to all registered users with no saved payments, so if if anyone decided to not save any payment method their payment will be saved regardless? This could be undesirable UX. IMO this should apply only to those shoppers who really registered now

@syadupathi-sf syadupathi-sf merged commit c0d7536 into 1cc_bugs Feb 4, 2026
42 checks passed
@syadupathi-sf syadupathi-sf deleted the syadupathi.W-21005976.saveRegUserInfo branch February 4, 2026 20:56
kumaravinashcommercecloud pushed a commit that referenced this pull request Feb 9, 2026
@syadupathi-sf @dannyphan2000
@W-21111863 @W-21109829 @W-21005976 @W-21109850 1CC Bug Fixes (#3638)
0e107a7 
* @W-21109850: Continue as Guest skips entering phone number (#3626)

* One click checkout

* changes to fix install, tests and lint - needs to be reviewed

* revert the test change in pwa-kit-runtime

* @W-20892497 Show Phone number in Contact Info summary (#3576)

* W-20892497 Show Phone number in Contact Info summary

* fix lint

* @W-20892592 Remove gift messaging for multi shipment (#3579)

* W-20892592 Remove gift messaging for multi shipment

* translations

* @W-20892530 @W-20892577 Billing Address Validation and Using contact phone for user registration (#3583)

* W-20892530 Billing Address Validation

* W-20892577 save contact info phone

* Fix SDK tests (#3593)

* fix sdk tests and app bundle size

* fix lint

* @ W-20540715 Address 1CC feature branch review comments (#3619)

* address first set of comments

* address rest of code review comments

* reverting default.js changes

* fix package versions

* shipping options fix

* attempt to fix flaky tests

* passwordless mode updates

* @W-21109850: Continue as Guest skips entering phone number

Signed-off-by: d.phan <d.phan@salesforce.com>

* fix import

Signed-off-by: d.phan <d.phan@salesforce.com>

* translations

* fix user not found error

---------

Signed-off-by: d.phan <d.phan@salesforce.com>
Co-authored-by: Sushma Yadupathi <syadupathi@salesforce.com>
Co-authored-by: syadupathi-sf <66088780+syadupathi-sf@users.noreply.github.com>

* W-21111863 Hide user registration for returning shoppers who chose to checkout as guest (#3634)

* @W-21005976 Save newly registered user's info when they leave checkout… (#3632)

* W-21005976 Save newly registered user's info when they leave checkout and return

* code review comments

* @W-21109829 Editing shipping options in multi shipment scenarios (#3637)

* W-21109829 Editing shipping options in multi shipment scenarios

* minor text changes

* remove unnecessary test

---------

Signed-off-by: d.phan <d.phan@salesforce.com>
Signed-off-by: syadupathi-sf <66088780+syadupathi-sf@users.noreply.github.com>
Co-authored-by: Danny Phan <125327707+dannyphan2000@users.noreply.github.com>
unandyala pushed a commit that referenced this pull request Feb 10, 2026
@syadupathi-sf @dannyphan2000 @unandyala
@W-21111863 @W-21109829 @W-21005976 @W-21109850 1CC Bug Fixes (#3638)
9395d61 
* @W-21109850: Continue as Guest skips entering phone number (#3626)

* One click checkout

* changes to fix install, tests and lint - needs to be reviewed

* revert the test change in pwa-kit-runtime

* @W-20892497 Show Phone number in Contact Info summary (#3576)

* W-20892497 Show Phone number in Contact Info summary

* fix lint

* @W-20892592 Remove gift messaging for multi shipment (#3579)

* W-20892592 Remove gift messaging for multi shipment

* translations

* @W-20892530 @W-20892577 Billing Address Validation and Using contact phone for user registration (#3583)

* W-20892530 Billing Address Validation

* W-20892577 save contact info phone

* Fix SDK tests (#3593)

* fix sdk tests and app bundle size

* fix lint

* @ W-20540715 Address 1CC feature branch review comments (#3619)

* address first set of comments

* address rest of code review comments

* reverting default.js changes

* fix package versions

* shipping options fix

* attempt to fix flaky tests

* passwordless mode updates

* @W-21109850: Continue as Guest skips entering phone number

Signed-off-by: d.phan <d.phan@salesforce.com>

* fix import

Signed-off-by: d.phan <d.phan@salesforce.com>

* translations

* fix user not found error

---------

Signed-off-by: d.phan <d.phan@salesforce.com>
Co-authored-by: Sushma Yadupathi <syadupathi@salesforce.com>
Co-authored-by: syadupathi-sf <66088780+syadupathi-sf@users.noreply.github.com>

* W-21111863 Hide user registration for returning shoppers who chose to checkout as guest (#3634)

* @W-21005976 Save newly registered user's info when they leave checkout… (#3632)

* W-21005976 Save newly registered user's info when they leave checkout and return

* code review comments

* @W-21109829 Editing shipping options in multi shipment scenarios (#3637)

* W-21109829 Editing shipping options in multi shipment scenarios

* minor text changes

* remove unnecessary test

---------

Signed-off-by: d.phan <d.phan@salesforce.com>
Signed-off-by: syadupathi-sf <66088780+syadupathi-sf@users.noreply.github.com>
Co-authored-by: Danny Phan <125327707+dannyphan2000@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaravinashcommercecloud kumaravinashcommercecloud kumaravinashcommercecloud approved these changes

Assignees

No one assigned

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@syadupathi-sf @cc-prodsec @kumaravinashcommercecloud