Skip to content

@W-21066774: Add config flag to enable/disable HttpOnly session cookies #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unandyala merged 8 commits into from
Feb 6, 2026
Merged

@W-21066774: Add config flag to enable/disable HttpOnly session cookies #3635

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2383dbf
Add config flag to enable httponly session cookies
unandyala Feb 4, 2026
d290880
Add config flag to enable httponly session cookies
unandyala Feb 4, 2026
c252197
Add config flag to enable httponly session cookies
unandyala Feb 4, 2026
87605cc
Add config flag to enable httponly session cookies
unandyala Feb 4, 2026
1a477ca
Revert "Add config flag to enable httponly session cookies"
unandyala Feb 4, 2026
14be2b3
Add config flag to enable httponly session cookies
unandyala Feb 4, 2026
9314ab3
Add config flag to enable httponly session cookies
unandyala Feb 4, 2026
202a2df
Add config flag to enable httponly session cookies
unandyala Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/pwa-kit-dev/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
## v3.16.0-dev (Dec 17, 2025)
Add configuration flag `disableHttpOnlySessionCookies` to `ssrParameters` [#3635](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3635)

## v3.15.0 (Dec 17, 2025)

## v3.14.0 (Nov 04, 2025)
Expand Down
9 changes: 7 additions & 2 deletions packages/pwa-kit-dev/bin/pwa-kit-dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,11 +253,16 @@ const main = async () => {
error('Could not determine app entrypoint.')
process.exit(1)
}

// Load config to get envBasePath from ssrParameters for local development
// This mimics how MRT sets the MRT_ENV_BASE_PATH system environment variable
const config = getConfig() || {}
const disableHttpOnlySessionCookies =
config.ssrParameters?.disableHttpOnlySessionCookies || true
execSync(`${babelNode} ${inspect ? '--inspect' : ''} ${babelArgs} ${entrypoint}`, {
env: {
...process.env,
...(noHMR ? {HMR: 'false'} : {})
...(noHMR ? {HMR: 'false'} : {}),
MRT_DISABLE_HTTPONLY_SESSION_COOKIES: disableHttpOnlySessionCookies
}
})
})
Expand Down
2 changes: 2 additions & 0 deletions packages/pwa-kit-react-sdk/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
## v3.16.0-dev (Dec 17, 2025)
Add configuration flag `disableHttpOnlySessionCookies` to `ssrParameters` [#3635](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3635)

## v3.15.0 (Dec 17, 2025)

## v3.14.0 (Nov 04, 2025)
Expand Down
1 change: 1 addition & 0 deletions packages/pwa-kit-react-sdk/src/ssr/server/react-rendering.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,7 @@ const renderApp = (args) => {
__CONFIG__: config,
__PRELOADED_STATE__: appState,
__ERROR__: error,
__MRT_DISABLE_HTTPONLY_SESSION_COOKIES__: process.env.MRT_DISABLE_HTTPONLY_SESSION_COOKIES,
// `window.Progressive` has a long history at Mobify and some
// client-side code depends on it. Maintain its name out of tradition.
Progressive: getWindowProgressive(req, res)
Expand Down
1 change: 1 addition & 0 deletions packages/template-retail-react-app/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- Util function for passwordless callback URI [#3630](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3630)
- [BREAKING] Remove unused absoluteUrl util from retail react app [#3633](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3633)
- Allow shopper to manually input OTP during passwordless login [#3554](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3554)
- Add configuration flag `disableHttpOnlySessionCookies` to `ssrParameters` [#3635](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3635)

## v8.3.0 (Dec 17, 2025)
- [Bugfix] Fix Forgot Password link not working from Account Profile password update form [#3493](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3493)
Expand Down
1 change: 1 addition & 0 deletions packages/template-retail-react-app/config/default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ module.exports = {
],
ssrParameters: {
ssrFunctionNodeVersion: '22.x',
disableHttpOnlySessionCookies: true,
Copy link
Contributor

@vcua-mobify vcua-mobify Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we have true as the default in pwa-kit-dev if this is undefined so we probably don't need to update the config templates in the generator.

Should we have a comment explaining why this is true by default?

Copy link
Contributor Author

@unandyala unandyala Feb 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good to add it for clarity. Also changed value to false

proxyConfigs: [
{
host: 'kv7kzm78.api.commercecloud.salesforce.com',
Expand Down
Loading