Skip to content

@W-21190081 Add spinner during OTP verification #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
syadupathi-sf merged 2 commits into from
Feb 6, 2026
Merged

@W-21190081 Add spinner during OTP verification #3643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30057c6
W-21190081 Add spinner during OTP verification
syadupathi-sf Feb 5, 2026
ae42c42
Merge branch 'develop' into syadupathi.W-21190081.otpSpinner
syadupathi-sf Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/template-retail-react-app/app/components/otp-auth/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
Button,
Input,
SimpleGrid,
Spinner,
Stack,
Text,
HStack,
Expand Down Expand Up @@ -271,6 +272,17 @@ const OtpAuth = ({
))}
</SimpleGrid>

{/* Loading spinner during verification */}
{isVerifying && (
<Spinner
size="sm"
color="blue.500"
role="status"
aria-live="polite"
data-testid="otp-verifying-spinner"
/>
)}

{/* Error message */}
{error && (
<Text fontSize="sm" color="red.500" textAlign="center">
Expand Down
35 changes: 35 additions & 0 deletions packages/template-retail-react-app/app/components/otp-auth/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,41 @@ describe('OtpAuth', () => {
await user.type(otpInputs[7], '8')
expect(otpInputs[7]).toHaveFocus()
})

test('shows spinner while OTP is being verified', async () => {
const deferred = {}
const verifyingPromise = new Promise((resolve) => {
deferred.resolve = resolve
})
const mockVerify = jest.fn().mockReturnValue(verifyingPromise)

const user = userEvent.setup()
renderWithProviders(
<OtpAuth
isOpen={true}
onClose={mockOnClose}
form={mockForm}
handleOtpVerification={mockVerify}
handleSendEmailOtp={mockHandleSendEmailOtp}
/>
)

expect(screen.queryByTestId('otp-verifying-spinner')).not.toBeInTheDocument()

const otpInputs = screen.getAllByRole('textbox')
fireEvent.paste(otpInputs[0], {
clipboardData: {getData: () => '12345678'}
})

await waitFor(() => {
expect(screen.getByTestId('otp-verifying-spinner')).toBeInTheDocument()
})

deferred.resolve({success: true})
await waitFor(() => {
expect(screen.queryByTestId('otp-verifying-spinner')).not.toBeInTheDocument()
})
})
})

describe('Keyboard Navigation', () => {
Expand Down
Loading