Skip to content

@W-20726574 Bring up to date with #3644#3653

Merged
noahadams merged 1 commit intomrt-feature-branch-mrt-ref-app-aws-serverless-expressfrom
mrt-feature-branch-support-basepath-in-aws-serverless-express-refapp
Feb 10, 2026
Merged

@W-20726574 Bring up to date with #3644#3653
noahadams merged 1 commit intomrt-feature-branch-mrt-ref-app-aws-serverless-expressfrom
mrt-feature-branch-support-basepath-in-aws-serverless-express-refapp

Conversation

@noahadams
Copy link
Collaborator

@noahadams noahadams commented Feb 10, 2026

Description

Fixes some edge case bugs in the previous base path handling middleware, adds some more specific testing. Backport of feedback improvements from #3644, followup to #3641

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • in template-mrt-reference-app, fixes up base path middleware to detect base path from req.path, and then slice it off of req.url, also handle case where basepath is the only path segment (e.g, not followed by a trailing slash)
  • lowers logging to debug level
  • adds a deeper test case that checks resolved path and looks for hte base path driving env var in the echo endpoints response

How to Test-Drive This PR

  • checkout branch, and with Node.js v22.x installed and active, from checkout root run
  • npm ci
  • cd packages/template-mrt-reference-app
  • npm run test

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@noahadams noahadams requested a review from a team as a code owner February 10, 2026 01:08
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Feb 10, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@noahadams noahadams merged commit dbce231 into mrt-feature-branch-mrt-ref-app-aws-serverless-express Feb 10, 2026
37 of 42 checks passed
@noahadams noahadams deleted the mrt-feature-branch-support-basepath-in-aws-serverless-express-refapp branch February 10, 2026 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants