[Node 24][V3] Update Dependencies (@W-21177051@)#3663
Merged
Conversation
Collaborator
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
bendvc
reviewed
Feb 23, 2026
| jest.useFakeTimers() | ||
| // doNotFake 'performance' so that the polyfilled performance.mark/measure | ||
| // methods (from perf_hooks) remain available in the jsdom environment | ||
| jest.useFakeTimers({doNotFake: ['performance']}) |
bendvc
approved these changes
Feb 23, 2026
Contributor
bendvc
left a comment
There was a problem hiding this comment.
Looks good. Thanks for keeping the project up-to-date 👍
bfeister
approved these changes
Feb 24, 2026
syadupathi-sf
approved these changes
Feb 26, 2026
rasbhat
pushed a commit
that referenced
this pull request
Mar 5, 2026
* Bump dependencies versions * Update lock files * Fix npm registry * Update jest breaking changes * One click checkout tests with configurable mocks * Solve merge conflicts * Update package-lock.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR upgrades outdated dependencies across packages to improve security and compatibility with Node 24:
jest-cli,jest-environment-jsdom,jest-environment-jsdom-global,jest-fetch-mock, andbabel-jest. Resolved breaking changes including ESM module resolution in jsdom, fake timer spy behavior, hook registration timing in Jest Circus, andcustomExportConditionsdefaults.pwa-kit-devwith API compatibility verified for bundle creation. Thefinalize()method now returns a Promise and addressed lint errors from floating promises.fs.rm/fs.rmSync: Removed therimrafdependency. Node's built-infs.rmis stable since Node 14.14 and provides equivalent behavior withrecursiveandforceoptions, works cross-platform.Refactor one-click checkout tests for Jest 29 upgrade included:
one-click-contact-info.test.js: Replacedjest.resetModules()+ dynamic imports with configurable top-leveljest.fn()mocks overridden per test.one-click-shipping-address.test.js: Eliminated nesteddescribe/beforeAllblocks usingjest.resetModules()+ module caching workaround. Replaced with configurable top-level mocks and stable return value references.one-click-shipping-options.test.js: Eliminated nesteddescribe/beforeAllblocks. Replaced with configurable top-level mocks and stable return value references to prevent infinite re-render loops.index.test.js: Un skipped theCan add address during checkout as a registered customertest by adapting it to handle one-click checkout's auto advance behavior.No public APIs were changed. All tests pass on Node 18, 20, 22, and 24.
Types of Changes
Changes
jest,babel-jest,jest-clifrom^26.6.3to^29.7.0across all packagesjest-environment-jsdomto^29.7.0andjest-environment-jsdom-globalto^4.0.0jest-fetch-mockfrom^2.1.2to^3.0.3archiverfrom1.3.0to^7.0.1inpwa-kit-devrimrafwith Node.js built-infs.rm/fs.rmSyncinpwa-kit-devandinternal-lib-buildtestEnvironmentOptions.customExportConditions: ['node', 'node-addons']in Jest configs to fix ESM resolution foruuidandnanoidperformance.mark/performance.measurepolyfills in Jest setup for jsdom environmentjest.useFakeTimers()spy behavior inisland/index.test.js(explicitjest.spyOnforsetTimeout/clearTimeout)global.fetch.mockClear()call in_app-config/index.test.jsjest.resetModules()+ dynamic importsCan add address during checkout as a registered customerintegration testHow to Test-Drive This PR
npm testfrom the monorepo root to verify all packages passnpm testinpackages/template-retail-react-appto verify all 2369 tests pass (211 suites)npm testinpackages/pwa-kit-devto verify bundle/clean script utilities worknpm run buildsucceeds and produces a valid bundle (archiver upgrade)Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization