Skip to content

Fix missing redirectURL setting when calling payment instrument patch… #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amittapalli merged 1 commit into from
Feb 16, 2026
Merged

Fix missing redirectURL setting when calling payment instrument patch… #3670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions packages/template-retail-react-app/app/components/sf-payments-express-buttons/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,13 @@ const SFPaymentsExpressButtons = ({
// Find SF Payments payment instrument in created order
const orderPaymentInstrument = getSFPaymentsInstrument(order)

// Build the return URL (needed for updatePaymentInstrumentForOrder )
const baseReturnUrl = `${window.location.protocol}//${window.location.host}/checkout/payment-processing`
paymentData.returnUrl = baseReturnUrl +
'?orderNo=' + encodeURIComponent(createdOrderNo) +
'&zoneId=' + encodeURIComponent(zoneId) +
'&type=' + encodeURIComponent(paymentType)

try {
const paymentInstrumentBody = createPaymentInstrumentBody({
amount: order.orderTotal,
Expand Down Expand Up @@ -944,15 +951,7 @@ const SFPaymentsExpressButtons = ({

const paymentMethodSet = {
paymentMethods: paymentConfig.paymentMethods,
// inject country code into payment method set accounts (Adyen seems to need it but Stripe works with/without it)
paymentMethodSetAccounts:
paymentConfig.paymentMethodSetAccounts?.map((account) => ({
...account,
config: {
...account.config,
country: paymentCountryCode || fallbackCountryCode || 'US' // Inject country here
}
})) || []
paymentMethodSetAccounts: paymentConfig.paymentMethodSetAccounts || []
}
const config = {
theme: buildTheme({
Expand Down
Loading