-
Notifications
You must be signed in to change notification settings - Fork 212
@W-21294742: No error toast for non-applicable shipping method #3673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dannyphan2000
merged 16 commits into
develop
from
dannyphan2000.W-21294742.error-no-shipping-method-fix
Mar 2, 2026
Merged
Changes from 4 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6ac7ee3
@W-21294742: No error toast for non-applicable shipping method
dannyphan2000 6d96809
add changelog
dannyphan2000 c1059b8
fix for multi-shipment
dannyphan2000 61c0584
fix edge cases
dannyphan2000 36599d9
minor comment remove
dannyphan2000 9e6caa2
fixes
dannyphan2000 b010a1c
Merge branch 'develop' into dannyphan2000.W-21294742.error-no-shippin…
dannyphan2000 d9bb37f
fix duplicate error toast
dannyphan2000 d1e34b1
fix for false positives error toast
dannyphan2000 9cfb92d
Merge branch 'develop' into dannyphan2000.W-21294742.error-no-shippin…
dannyphan2000 8b86c8c
reuse util func
dannyphan2000 0c42066
Merge remote-tracking branch 'upstream/develop' into dannyphan2000.W-…
dannyphan2000 8700420
Merge branch 'develop' into dannyphan2000.W-21294742.error-no-shippin…
dannyphan2000 39a7ba2
lint fix test
dannyphan2000 b2f8482
fix a11y cart issue
dannyphan2000 736abe4
skip test temporarily
dannyphan2000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,13 +48,14 @@ export default function ShippingAddress(props) { | |
| const {enableUserRegistration = false, isShipmentCleanupComplete = true} = props | ||
| const {formatMessage} = useIntl() | ||
| const [isManualSubmitLoading, setIsManualSubmitLoading] = useState(false) | ||
| const [isMultiShipping, setIsMultiShipping] = useState(false) | ||
| const [openedByUser, setOpenedByUser] = useState(false) | ||
| const {data: customer} = useCurrentCustomer() | ||
| const currentBasketQuery = useCurrentBasket() | ||
| const {data: basket} = currentBasketQuery | ||
| const deliveryShipments = | ||
| basket?.shipments?.filter((shipment) => !isPickupShipment(shipment)) || [] | ||
| const hasMultipleDeliveryShipments = deliveryShipments.length > 1 | ||
| const [isMultiShipping, setIsMultiShipping] = useState(hasMultipleDeliveryShipments) | ||
| const [openedByUser, setOpenedByUser] = useState(false) | ||
|
Comment on lines
+56
to
+58
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice |
||
| const selectedShippingAddress = deliveryShipments[0]?.shippingAddress | ||
| const targetDeliveryShipmentId = deliveryShipments[0]?.shipmentId || 'me' | ||
| const isAddressFilled = selectedShippingAddress?.address1 && selectedShippingAddress?.city | ||
|
|
@@ -65,7 +66,7 @@ export default function ShippingAddress(props) { | |
| 'updateShippingAddressForShipment' | ||
| ) | ||
| const multishipEnabled = getConfig()?.app?.multishipEnabled ?? true | ||
| const hasMultipleDeliveryShipments = deliveryShipments.length > 1 | ||
|
|
||
| const {removeEmptyShipments} = useMultiship(basket) | ||
| const {updateItemsToDeliveryShipment} = useItemShipmentManagement(basket?.basketId) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change to Cart page I mentioned @patricksullivansf