@W-20615600 feat: Search popup Ask Shopping Agent banner and mobile layout#3682
Merged
sf-tejas-nadkarni merged 10 commits intodevelopfrom Feb 27, 2026
Merged
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
packages/template-retail-react-app/app/components/search/partials/ask-assistant-banner.jsx
Outdated
Show resolved
Hide resolved
packages/template-retail-react-app/app/components/search/partials/ask-assistant-banner.jsx
Outdated
Show resolved
Hide resolved
packages/template-retail-react-app/app/components/search/partials/ask-assistant-banner.jsx
Outdated
Show resolved
Hide resolved
shethj
reviewed
Feb 25, 2026
packages/template-retail-react-app/app/components/search/partials/ask-assistant-banner.test.jsx
Outdated
Show resolved
Hide resolved
shethj
reviewed
Feb 25, 2026
packages/template-retail-react-app/app/theme/components/project/search-suggestions.js
Outdated
Show resolved
Hide resolved
shethj
reviewed
Feb 26, 2026
packages/template-retail-react-app/app/components/search/partials/ask-assistant-banner.jsx
Outdated
Show resolved
Hide resolved
shethj
reviewed
Feb 26, 2026
| left={0} | ||
| right={0} | ||
| height="100vh" | ||
| overflowX="hidden" |
Contributor
There was a problem hiding this comment.
SearchSuggestions component is using negative margins:
marginLeft: -6 while here we're clipping the element with overflow hidden.
We must seek to address the core issue instead of having contradicting css.
Collaborator
Author
There was a problem hiding this comment.
The negative margin was to get a full-bleed look inside a padded container, and overflow hidden is used to hide the side effects of that breakout
refactoring the parent container is currently out of scope and this approach is only to meet the UX requirement. Since the feature is behind the perm, it won't impact the standard suggestion box
shethj
reviewed
Feb 26, 2026
packages/template-retail-react-app/app/components/search/partials/ask-assistant-banner.jsx
Outdated
Show resolved
Hide resolved
shethj
reviewed
Feb 26, 2026
shethj
previously approved these changes
Feb 26, 2026
alexvuong
previously approved these changes
Feb 27, 2026
5af0ecf
kevinxh
approved these changes
Feb 27, 2026
alexvuong
approved these changes
Feb 27, 2026
rasbhat
pushed a commit
that referenced
this pull request
Mar 5, 2026
…ayout (#3682) * feat: update the banner with click events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds and updates the "Ask Shopping Agent" banner in the search suggestions popup with a new layout, styling, and reliable full-bleed behavior on mobile and desktop.
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization