Skip to content

@W-20615600 feat: Search popup Ask Shopping Agent banner and mobile layout#3682

Merged
sf-tejas-nadkarni merged 10 commits intodevelopfrom
W-20615600-search-launch-location-update
Feb 27, 2026
Merged

@W-20615600 feat: Search popup Ask Shopping Agent banner and mobile layout#3682
sf-tejas-nadkarni merged 10 commits intodevelopfrom
W-20615600-search-launch-location-update

Conversation

@sf-tejas-nadkarni
Copy link
Collaborator

Description

Adds and updates the "Ask Shopping Agent" banner in the search suggestions popup with a new layout, styling, and reliable full-bleed behavior on mobile and desktop.

Screenshot 2026-02-20 at 9 58 13 AM Screenshot 2026-02-20 at 10 46 56 AM

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • Ask Shopping Agent banner
  • Full-bleed and mobile overlay
  • Assets and config

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@sf-tejas-nadkarni sf-tejas-nadkarni requested a review from a team as a code owner February 20, 2026 20:42
@sf-tejas-nadkarni sf-tejas-nadkarni added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Feb 20, 2026
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Feb 20, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Contributor

@sf-jhalak-maheshwari sf-jhalak-maheshwari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

left={0}
right={0}
height="100vh"
overflowX="hidden"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SearchSuggestions component is using negative margins:
marginLeft: -6 while here we're clipping the element with overflow hidden.

We must seek to address the core issue instead of having contradicting css.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The negative margin was to get a full-bleed look inside a padded container, and overflow hidden is used to hide the side effects of that breakout

refactoring the parent container is currently out of scope and this approach is only to meet the UX requirement. Since the feature is behind the perm, it won't impact the standard suggestion box

shethj
shethj previously approved these changes Feb 26, 2026
alexvuong
alexvuong previously approved these changes Feb 27, 2026
@sf-tejas-nadkarni sf-tejas-nadkarni dismissed stale reviews from alexvuong and shethj via 5af0ecf February 27, 2026 17:32
@sf-tejas-nadkarni sf-tejas-nadkarni merged commit fb3bf57 into develop Feb 27, 2026
42 checks passed
@sf-tejas-nadkarni sf-tejas-nadkarni deleted the W-20615600-search-launch-location-update branch February 27, 2026 23:01
rasbhat pushed a commit that referenced this pull request Mar 5, 2026
…ayout (#3682)

* feat: update the banner with click events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants