Skip to content

W-21281890: Address v1 vs v2 integration into PWA#3687

Merged
amittapalli merged 4 commits intot/team404/sfp-on-pwafrom
amittapalli/pwa-v1-v2-updates
Feb 23, 2026
Merged

W-21281890: Address v1 vs v2 integration into PWA#3687
amittapalli merged 4 commits intot/team404/sfp-on-pwafrom
amittapalli/pwa-v1-v2-updates

Conversation

@amittapalli
Copy link
Contributor

Address v1 vs v2 integration into PWA

Description

The ask is to prevent commerce-sdk-react from breaking. In order to do that, we would need to ensure that existing ShopperBasket hooks are set to v1 while introducing a separate set of ShopperBasketV2 hooks. Then the new set of V2 hooks will be used in template-retail-react-app package instead. Given there are many files that need to get updated in order to import v2 instead of v1, surface area is large.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@amittapalli amittapalli requested review from a team as code owners February 23, 2026 14:26
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Feb 23, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

const transferedTo = response?.customerInfo?.customerId

return {
// TODO: Convert invalidate to an update that removes the matching basket
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just a copy of a TODO from v1?

@amittapalli amittapalli merged commit e512848 into t/team404/sfp-on-pwa Feb 23, 2026
10 of 16 checks passed
@amittapalli amittapalli deleted the amittapalli/pwa-v1-v2-updates branch February 23, 2026 19:58
useAccessToken,
useCategory,
useShopperBasketsMutation
useShopperBasketsV2Mutation as useShopperBasketsMutation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong. Isn't it exported as useShopperBasketsMutation and not useShopperBasketsV2Mutation.

rasbhat pushed a commit that referenced this pull request Mar 5, 2026
* W-21281890 Address v1 vs v2 integration into PWA
rasbhat pushed a commit that referenced this pull request Mar 5, 2026
* W-21281890 Address v1 vs v2 integration into PWA
rasbhat pushed a commit that referenced this pull request Mar 5, 2026
* W-21281890 Address v1 vs v2 integration into PWA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants