W-21281890: Address v1 vs v2 integration into PWA#3687
Merged
amittapalli merged 4 commits intot/team404/sfp-on-pwafrom Feb 23, 2026
Merged
W-21281890: Address v1 vs v2 integration into PWA#3687amittapalli merged 4 commits intot/team404/sfp-on-pwafrom
amittapalli merged 4 commits intot/team404/sfp-on-pwafrom
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| const transferedTo = response?.customerInfo?.customerId | ||
|
|
||
| return { | ||
| // TODO: Convert invalidate to an update that removes the matching basket |
Collaborator
There was a problem hiding this comment.
Is this just a copy of a TODO from v1?
jeffraab-sfdc
approved these changes
Feb 23, 2026
sf-mkosak
reviewed
Feb 24, 2026
| useAccessToken, | ||
| useCategory, | ||
| useShopperBasketsMutation | ||
| useShopperBasketsV2Mutation as useShopperBasketsMutation |
There was a problem hiding this comment.
This seems wrong. Isn't it exported as useShopperBasketsMutation and not useShopperBasketsV2Mutation.
rasbhat
pushed a commit
that referenced
this pull request
Mar 5, 2026
* W-21281890 Address v1 vs v2 integration into PWA
rasbhat
pushed a commit
that referenced
this pull request
Mar 5, 2026
* W-21281890 Address v1 vs v2 integration into PWA
rasbhat
pushed a commit
that referenced
this pull request
Mar 5, 2026
* W-21281890 Address v1 vs v2 integration into PWA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address v1 vs v2 integration into PWA
Description
The ask is to prevent commerce-sdk-react from breaking. In order to do that, we would need to ensure that existing ShopperBasket hooks are set to v1 while introducing a separate set of ShopperBasketV2 hooks. Then the new set of V2 hooks will be used in template-retail-react-app package instead. Given there are many files that need to get updated in order to import v2 instead of v1, surface area is large.
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization