Skip to content

W-20911534: adding unit tests for sf-payments-express components#3689

Merged
nayanavishwa merged 1 commit intot/team404/sfp-on-pwafrom
nayana.vishwa/W-20911534-paymentExpressTests
Feb 25, 2026
Merged

W-20911534: adding unit tests for sf-payments-express components#3689
nayanavishwa merged 1 commit intot/team404/sfp-on-pwafrom
nayana.vishwa/W-20911534-paymentExpressTests

Conversation

@nayanavishwa
Copy link
Collaborator

@nayanavishwa nayanavishwa commented Feb 23, 2026

Description

Types of Changes

  • Includes unit tests for sf-payments-express components in template-retail-react-app package.

Coverage:
image

  • test results for app/pages/checkout/partials/sf-payments-sheet.test.js:
image
  • test results for app/utils/sf-payments-utils.test.js‎:
image image image
  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • template-retail-react-app/app/components/sf-payments-express/index.test.js
  • template-retail-react-app/app/components/sf-payments-express-buttons/index.test.js

How to Test-Drive This PR

  • checkout this branch and run npm run test at project directory.

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@nayanavishwa nayanavishwa requested a review from a team as a code owner February 23, 2026 21:38
@nayanavishwa nayanavishwa requested review from amittapalli and removed request for a team February 23, 2026 21:38
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Feb 23, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@rasbhat
Copy link

rasbhat commented Feb 23, 2026

Linting: Please run npm run lint. If you hit any issues, you can usually resolve them quickly with npm run lint:fix

Testing: We aim for at least 70% test coverage. Please attach the coverage report along with the test results.

@nayanavishwa nayanavishwa added skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated labels Feb 23, 2026
@nayanavishwa nayanavishwa requested review from a team February 24, 2026 00:20
@nayanavishwa nayanavishwa force-pushed the nayana.vishwa/W-20911534-paymentExpressTests branch from 316e447 to f14390c Compare February 24, 2026 19:57
@nayanavishwa nayanavishwa force-pushed the nayana.vishwa/W-20911534-paymentExpressTests branch from f14390c to b0bf522 Compare February 24, 2026 22:46
@nayanavishwa nayanavishwa merged commit a159589 into t/team404/sfp-on-pwa Feb 25, 2026
12 of 42 checks passed
@nayanavishwa nayanavishwa deleted the nayana.vishwa/W-20911534-paymentExpressTests branch February 25, 2026 18:46
rasbhat pushed a commit that referenced this pull request Mar 5, 2026
…-20911534-paymentExpressTests

W-20911534: adding unit tests for sf-payments-express components
rasbhat pushed a commit that referenced this pull request Mar 5, 2026
…-20911534-paymentExpressTests

W-20911534: adding unit tests for sf-payments-express components
rasbhat pushed a commit that referenced this pull request Mar 5, 2026
…-20911534-paymentExpressTests

W-20911534: adding unit tests for sf-payments-express components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants