W-21354832 increase bundle size, fix the package.json lock file surgically and other changes#3704
Merged
amittapalli merged 7 commits intot/team404/sfp-on-pwafrom Mar 3, 2026
Conversation
…cally for now, add change log
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
jeffraab-sfdc
approved these changes
Mar 3, 2026
nayanavishwa
reviewed
Mar 3, 2026
| { | ||
| "path": "build/main.js", | ||
| "maxSize": "90 kB" | ||
| "maxSize": "98 kB" |
Collaborator
There was a problem hiding this comment.
are we allowed to increase bundle size?
Other solution might be to lazy load payment express components.
rasbhat
pushed a commit
that referenced
this pull request
Mar 5, 2026
…cally and other changes (#3704) * W-21354832 increase bundle size, fix the package.json lock file surgically for now, add change log * W-21354832 increase bundle size for vendor,js * W-21354832 address additional linting errors in handle bars, change log * W-21354832 add another change log * fix failing unit tests afte isomorphic bump * Fix mocks for failing unit tests * Revert default.js to original state and add only the sfpayments section
rasbhat
pushed a commit
that referenced
this pull request
Mar 5, 2026
…cally and other changes (#3704) * W-21354832 increase bundle size, fix the package.json lock file surgically for now, add change log * W-21354832 increase bundle size for vendor,js * W-21354832 address additional linting errors in handle bars, change log * W-21354832 add another change log * fix failing unit tests afte isomorphic bump * Fix mocks for failing unit tests * Revert default.js to original state and add only the sfpayments section
rasbhat
pushed a commit
that referenced
this pull request
Mar 5, 2026
…cally and other changes (#3704) * W-21354832 increase bundle size, fix the package.json lock file surgically for now, add change log * W-21354832 increase bundle size for vendor,js * W-21354832 address additional linting errors in handle bars, change log * W-21354832 add another change log * fix failing unit tests afte isomorphic bump * Fix mocks for failing unit tests * Revert default.js to original state and add only the sfpayments section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization