Skip to content

@W-21451244 Mobile launch location support and header icon fixes#3724

Merged
sf-tejas-nadkarni merged 5 commits intodevelopfrom
W-21451244-launch-location-mobile
Mar 5, 2026
Merged

@W-21451244 Mobile launch location support and header icon fixes#3724
sf-tejas-nadkarni merged 5 commits intodevelopfrom
W-21451244-launch-location-mobile

Conversation

@sf-tejas-nadkarni
Copy link
Collaborator

Adds mobile support for launch location and updates header icons

Description

Mobile support & header

  • Header : Adjustments for mobile and header icon behavior.
  • Search : Updates for mobile layout/behavior.
  • Ask Assistant banner : Improved layout and content for mobile (e.g. Ask Shopping Agent).
  • Theme : Header styling and layout updates to support the new header/icons and mobile.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • W-21451244 – Launch location (mobile)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@sf-tejas-nadkarni sf-tejas-nadkarni requested a review from a team as a code owner March 5, 2026 18:10
@sf-tejas-nadkarni sf-tejas-nadkarni added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Mar 5, 2026
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Mar 5, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

alexvuong
alexvuong previously approved these changes Mar 5, 2026
launchChatFromUtils()
clearInput()
}, [launchChat, clearInput])
}, [setPrechatFieldsForNewSession, clearInput])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sf-tejas-nadkarni can we add some documentation on what is happening here? maybe a JSDOC for function

Copy link
Contributor

@sf-jhalak-maheshwari sf-jhalak-maheshwari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except one jsdoc consideration

@sf-tejas-nadkarni sf-tejas-nadkarni merged commit 4ff3c4f into develop Mar 5, 2026
42 checks passed
@sf-tejas-nadkarni sf-tejas-nadkarni deleted the W-21451244-launch-location-mobile branch March 5, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants