Closed
Conversation
* PWA on SFP spike * sfp on pwa part 1 * use new payment instrument request * conditionally render express box * add ShopperPayments tests * lint and tests * address comments * clean up --------- Co-authored-by: Jeff Raab <jraab@salesforce.com>
* render paypal * refactor shopper config checker
* refactor shopper config checker * baskets v2 temp commit * complete paypal and code clean up * address comments * fix
* @W-19685609 Express on PDP with Temporary Basket * Address Code Review: Fix comments, remove eagerly created validations, move temp basket to its a hook, i10n for errors, etc * Address Code Review: Fix additional comments, i10 labels, set keepPreviousData to false by default in current basket hook * Address Code Review: do not set keepPreviousData flag to true in useCurrentBasket hook until further testing confirms that it is needed * Address updates to SDK event changes in payment sheet * Remove the optional keepPreviousData property setting in usecurrentbasket hook * Undo i10 call for an error that nees to be looged into console only * Reset maximumButtonCount to 1 * Remove commented line * Replace undefined with empty function for onclick action in payment sheet
…/sfp-update-amount-prevent-reinit @W-20117176 : Call updateAmount on Order Total change
* W-19443266: Handle Failure use-cases by calling Fail Order where necessary. Also refactor the client-secret retrieval since the response structure has changed.
…/order-confirmation-hide-sfp-payment-details @W-19799923: Remove payment details on order confirmation page for SFP orders
…/stripe-setup-future-usage-mismatch Stripe setup future usage mismatch
…emove private client default
…20911530-unitTest W-20911530: added unit tests for payments related files.
…cally and other changes (#3704) * W-21354832 increase bundle size, fix the package.json lock file surgically for now, add change log * W-21354832 increase bundle size for vendor,js * W-21354832 address additional linting errors in handle bars, change log * W-21354832 add another change log * fix failing unit tests afte isomorphic bump * Fix mocks for failing unit tests * Revert default.js to original state and add only the sfpayments section
…/fail-order-on-redirect W-21372336: Fail Order for redirect based payments
…/stripe-caching-for-display-spm-fix-tests W-21411273, W-21434212: Fix for Display SPMs at checkout due to caching issues and Fix for failing tests on feature branch
…/merge-changes-from-develop W-21436534: Merge from Develop to feature branch
* W-21432256: address code review comments from PWA team
…/payment-sheet-zone-id W-21324157: Zone ID updated to use paymentconfig zoneID in Payment Sheet
…-20911530-UT W-20911530: fixing failing unit test
…ommerceCloud/pwa-kit into t/team404/sfp-on-pwa merging
…_REVALIDATE Made-with: Cursor
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Author
|
This PR has been squash merged to develop in this PR here: #3725. Closing this PR . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization