Skip to content

feat: pd-support @W-21227485#3727

Merged
mjuraschik merged 1 commit intodevelopfrom
feat/pd-support
Mar 6, 2026
Merged

feat: pd-support @W-21227485#3727
mjuraschik merged 1 commit intodevelopfrom
feat/pd-support

Conversation

@mjuraschik
Copy link
Contributor

@mjuraschik mjuraschik commented Mar 5, 2026

Description

Page Designer OOTB Support with PWA:

Brings in storefront-next-runtime package for PD design support
Aligns Page, Region and Component components with patterns for design mode
Added components needed for easier isml to react migration

  • New version of ShopperExperience components in commerce-sdk-react; Old components still kept for backwards compatibility
  • template-retail-react-app updated to have PD integration by default

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@mjuraschik mjuraschik requested a review from a team as a code owner March 5, 2026 21:56
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Mar 5, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@mjuraschik mjuraschik force-pushed the feat/pd-support branch 2 times, most recently from 9b21d76 to 70cfd91 Compare March 5, 2026 22:08
@mjuraschik
Copy link
Contributor Author

Follow up PR from #3654 (was created from a Fork)

@mjuraschik mjuraschik force-pushed the feat/pd-support branch 5 times, most recently from 6823381 to 7aca615 Compare March 5, 2026 23:05
@mjuraschik
Copy link
Contributor Author

@mjuraschik mjuraschik force-pushed the feat/pd-support branch 3 times, most recently from de2192b to f680249 Compare March 6, 2026 11:23
@@ -1,4 +1,5 @@
## v5.1.0-dev
- Add Page Designer Support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need PR link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

"@salesforce/pwa-kit-dev": "3.17.0-dev",
"@salesforce/pwa-kit-react-sdk": "3.17.0-dev",
"@salesforce/pwa-kit-runtime": "3.17.0-dev",
"@salesforce/storefront-next-runtime": "0.1.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried testing this PR on a generated project? You may need to override the react-router package as well, the react-router required in pwa-kit template is v5, but we are asking >=7.0 in peerDependency, if the depedencies not aligned, when you first start generated project, npm i will fail unless you use npm i --legacey-run-dep which we don't want customers to do.

"peerDependencies": {
        "@react-router/fs-routes": ">=7.0.0",
        "@react-router/dev": ">=7.0.0",
        "react": ">=19.0.0",
        "react-dom": ">=19.0.0",
        "react-router": ">=7.0.0"
    },

To test generation locally,

GENERATOR_PRESET=retail-react-app-demo node packages/pwa-kit-create-app/scripts/create-mobify-app.js --outputDir ./preset-retail-react-app-demo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2026-03-06 at 19 07 21

@mjuraschik mjuraschik enabled auto-merge (squash) March 6, 2026 18:47
@mjuraschik mjuraschik merged commit 17f0e18 into develop Mar 6, 2026
42 checks passed
@mjuraschik mjuraschik deleted the feat/pd-support branch March 6, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants