Merged
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
9b21d76 to
70cfd91
Compare
Contributor
Author
|
Follow up PR from #3654 (was created from a Fork) |
6823381 to
7aca615
Compare
Contributor
Author
de2192b to
f680249
Compare
alexvuong
reviewed
Mar 6, 2026
| @@ -1,4 +1,5 @@ | |||
| ## v5.1.0-dev | |||
| - Add Page Designer Support | |||
alexvuong
reviewed
Mar 6, 2026
| "@salesforce/pwa-kit-dev": "3.17.0-dev", | ||
| "@salesforce/pwa-kit-react-sdk": "3.17.0-dev", | ||
| "@salesforce/pwa-kit-runtime": "3.17.0-dev", | ||
| "@salesforce/storefront-next-runtime": "0.1.1", |
Contributor
There was a problem hiding this comment.
Have you tried testing this PR on a generated project? You may need to override the react-router package as well, the react-router required in pwa-kit template is v5, but we are asking >=7.0 in peerDependency, if the depedencies not aligned, when you first start generated project, npm i will fail unless you use npm i --legacey-run-dep which we don't want customers to do.
"peerDependencies": {
"@react-router/fs-routes": ">=7.0.0",
"@react-router/dev": ">=7.0.0",
"react": ">=19.0.0",
"react-dom": ">=19.0.0",
"react-router": ">=7.0.0"
},
To test generation locally,
GENERATOR_PRESET=retail-react-app-demo node packages/pwa-kit-create-app/scripts/create-mobify-app.js --outputDir ./preset-retail-react-app-demo
f680249 to
23b1e56
Compare
alexvuong
approved these changes
Mar 6, 2026
shethj
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Page Designer OOTB Support with PWA:
Brings in storefront-next-runtime package for PD design support
Aligns Page, Region and Component components with patterns for design mode
Added components needed for easier isml to react migration
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization