[release] Avoid accidentally releasing the mcp package #3729
Merged
Conversation
During `--package sdk` bumps, lerna version bumps all packages including `@salesforce/pwa-kit-mcp`. The independent packages are then restored to their pre-bump versions, but MCP carries a dev version in the repo that should never appear in a released SDK. This change restores MCP to its latest published npm version (via `npm info @latest`) instead of the repo dev version, and moves `getLatestVersion` to shared utils so it can be reused.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
shethj
reviewed
Mar 6, 2026
| const {location, version: oldVersion} = pkg | ||
| const {name, location, version: repoVersion} = pkg | ||
| let restoreVersion = repoVersion | ||
| if (name === '@salesforce/pwa-kit-mcp') { |
Contributor
There was a problem hiding this comment.
Dumb question: Instead of restoring a version back, can't we update the bump-version script to skip this package when updating versions ?
Or do we not have control over that since it's lerna driven ?
Contributor
Author
There was a problem hiding this comment.
Yeah, our script piggy backs on Lerna. So we had to restore the version like that afterwards.
shethj
approved these changes
Mar 6, 2026
Contributor
shethj
left a comment
shethj
left a comment
There was a problem hiding this comment.
Thanks a lot for adding this tweak in. Saves effort during releases 👍
vcua-mobify
approved these changes
Mar 6, 2026
Contributor
vcua-mobify
left a comment
vcua-mobify
left a comment
There was a problem hiding this comment.
Thanks for this @vmarta !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since pwa-kit-mcp package is to be released separately, whenever we bump up the versions of the SDK packages, we need to:
How to test drive the PR
Let's try bumping up the SDK versions:
npm run bump-version -- 3.20.0in your terminalThe result of
bump-versionscript should look like this: