HDR support - environment and image based lighting.#72
HDR support - environment and image based lighting.#72dtracers wants to merge 6 commits intoSaltieRL:masterfrom
Conversation
Abbondanzo
left a comment
There was a problem hiding this comment.
Couple of quick comments and the file conflicts will also have to get resolved at some point
| storageMemoize(async () => { | ||
| const { default: hdr } = await import( | ||
| // @ts-ignore | ||
| /* webpackChunkName: "Environment" */ "../../assets/models/textures/Environment/Environment.hdr" |
There was a problem hiding this comment.
No, I haven't finished final render yet, current environment texture is a testrender I made.
There was a problem hiding this comment.
I think it is okay to put the test render in. It is honestly high quality enough for temporary use.
@Abbondanzo is there a way to flag the render under beta?
There was a problem hiding this comment.
is there a way to flag the render under beta?
Not entirely, but we can flag the version number in package.json as 0.7.0b or something of that nature. Publishing only happens once we cut releases in this repo
|
This pull request introduces 1 alert when merging f77aea6 into d67de56 - view on LGTM.com new alerts:
|
Fixes #64