fix: Client.Stop does not terminate stdio MCP server processes, so direct callers leak subprocesses#755
Closed
sam-saffron-jarvis wants to merge 1 commit into
Closed
Conversation
…rect callers leak subprocesses
Owner
|
Implemented the important changes from this PR directly in main worktree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
internal/mcp.Clientto retain a stdio process cancel func when it starts command-based MCP serversClient.Stop()to invoke that cancel func before closing the MCP session, so direct callers stop the stdio process group instead of only closing the protocol sessionStop()still behaves like a clean stopClient.Stop()also terminates that leaked childWhy this is high-value
Direct
client.Start(...); defer client.Stop()call sites interm-llm mcp ...and the MCP browser/test flows were relying onStop()to clean up stdio servers, butStop()previously only closed the MCP session. Because the command itself was tied to a cancelable context thatStop()did not own, direct callers could leave behind helper subprocesses or descendant daemons after returning.This is high-value because leaked MCP helper processes accumulate over time, keep ports and file descriptors open, and can make later MCP interactions flaky or interfere with authenticated/background services.
Validation
gofmt -w internal/mcp/client.go internal/mcp/client_test.gogo build ./...go test ./...TestClientStop_CancelsStdioProcessGroupcovering the specific leak path