fix: keep active sidebar session messages cached#764
Merged
SamSaffron merged 1 commit intoJun 3, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the web sidebar message-cache eviction so the active session is never evicted when the UI caps cached message histories at 10 sessions.
Also prefer
lastMessageAtover creation time when choosing which non-active sessions stay cached.Why
Repro from Sam: click sidebar sessions 1, 2, 3, ... 10, then click session 11. If session 11 sits below the first 10 entries, it opens blank.
The lazy-load path hydrated session 11, then
saveSessions()immediately evicted its messages because eviction kept the 10 newest-created sessions, not the active session. The render after hydration then had an active_serverOnlystub with no messages. Tiny little footgun; very committed to being exactly off-by-one adjacent.Tests
mise exec node@24.15.0 -- node internal/serveui/static/app_core_test.jsinternal/serveui/static/*_test.jsviamise exec node@24.15.0 -- nodego build ./...go test ./internal/toolspassesgo test ./...mostly passed, with one transient failure ininternal/tools(TestRunAgentScriptTool_TimeoutKillsGrandchildren) that passed on direct rerun