fix: resume active runs for job notifications#784
Merged
SamSaffron merged 1 commit intoJun 9, 2026
Merged
Conversation
d19aa8a to
a10891f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Finishes the
queue_agent notify_when_doneweb behavior for both active and idle loaded sessions.Two cases were broken/underspecified:
done.This PR now handles both:
AutoContinuenotification interjection and continue at text-only turn boundariesWhy
notify_when_doneshould mean “tell the originating conversation and let it carry on,” not “leave a note somewhere and hope the human notices.” Waiting is the bad path; notification should be the good path.Review notes
Reviewed with
claude-bin:opus-max. I folded in the correctness nits before opening/pushing:MaxTurnsExceededError; if no turn budget remains, the notice stays pending and the current response completesVerification