Application priority bug #1694
Merged
Application priority bug #1694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty is reorganized
1 task
Snorre98
commented
Feb 14, 2025
Snorre98
commented
Feb 14, 2025
Snorre98
changed the title
Snorre98
commented
Feb 14, 2025
emsoraffa
reviewed
Feb 20, 2025
nemisis84
requested changes
Feb 25, 2025
Contributor
nemisis84
left a comment
nemisis84
left a comment
There was a problem hiding this comment.
Haven't taken a deep look into this., but leaving a comment anyway The algorithm itself is probably fine and it seems to work in the browser.
The test should be covering and documenting the edge cases. However, I think all tests should have a docstring describing the test case.
nemisis84
approved these changes
Mar 18, 2025
Contributor
nemisis84
left a comment
nemisis84
left a comment
There was a problem hiding this comment.
Only approving because I have to. But nice that you added docstrings
robines
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 replaced this:#1594
There was a bug which made applicant priority of positions incorrect. This is because when priority is manipulated the total count of applications was including withdrawn applications.
This was the case both when a new application was created, but also when applications where withdrawn.
There also is a bug where the priority is set incorrectly in the scenario when the applicant applies for a position which they previously had withdrawn the application from (could also be described as "re-activating" the application). The application gets the priority it had when it was withdrawn, which seems like unwanted behavior. I think the behavior should be that the "re-activated" application should get the lowest priority, like when the applicant applies for a position for the first time.