-
Notifications
You must be signed in to change notification settings - Fork 1
add billigv2 documentation #1832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
snorrekr
wants to merge
1
commit into
master
Choose a base branch
from
write-billig-documentiation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # Billig Integration v2 | ||
|
|
||
| In the words of a great visionary: | ||
| ``` | ||
| OMFG we are switching away from billig | ||
| Use what you've learnt from billig and find some experienced | ||
| pangs to help you out. Good luck! | ||
| ``` | ||
|
|
||
| As an experienced pang, I will try my best to conquer the task of defining the new Billig and what that entails for Samf4 | ||
|
|
||
|
|
||
| ## Usage | ||
| The new way we handle payment for events is through [Stripe](https://stripe.com/). They handle card data and payment; all we need to do is interact with their API. | ||
|
|
||
| The current implementation uses a form to send a POST request with the necessary values. Stripe handles the payment and reroutes back to samfundet.no where the ticket is shown. | ||
|
|
||
| The POST request is sent to three different URLs depending on the environment: | ||
| ``` | ||
| production: https://billettsalg.samfundet.no/pay | ||
| staging: https://billettsalg-staging.samfundet.no/pay | ||
| development*: http://localhost:4567/pay | ||
|
|
||
| *local is not set up for samf4 | ||
| ``` | ||
|
|
||
| The request contains: | ||
| - Ticket group and amount (for example: member/not member) | ||
| - Ticket type (member-card/email) | ||
| - membercard or email | ||
|
|
||
| The current implemenation is found [here](https://github.com/Samfundet/Samfundet/blob/master/app/views/events/buy.html.haml) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice om du linker til spesifikke linjer, sånn her: |
||
|
|
||
|
|
||
| Additionally, samfundet.no also handles showing the ticket after a successful purchase. Stripe reroutes to https://www.samfundet.no/arrangement/purchase_callback/:tickets where it gets the different ticket IDs and retrieves them from the database. The frontend allows the PDF to be downloaded. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Flowchart diagram for Stripe flyten hadde vært nice |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kan du vise selve datastrukturen, hvis det er relevant