-
Notifications
You must be signed in to change notification settings - Fork 1
1962 recreate samf3 navbar in samf 4 #1966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…mf 3 navbar items. Also split recruitment from the rest of the navbar links / items.
Bumps [debugpy](https://github.com/microsoft/debugpy) from 1.8.14 to 1.8.17. - [Release notes](https://github.com/microsoft/debugpy/releases) - [Commits](microsoft/debugpy@v1.8.14...v1.8.17) --- updated-dependencies: - dependency-name: debugpy dependency-version: 1.8.17 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add color palette * Add basic variables for text colors
* Create NewBadge component * biome
* Create Block composite components * Fix descending specificity * Decrease intensity of header/footer gradients slightly * Add storybook file * Remove storybook file (our new font isnt loading)
* Begin creating new event card component * Set all anchor tags' text-decoration to none * Use NewBadge. biome * adjust z-index * Add box shadow to event badge * Use placeholder image * Start badge and CTA logic, display location. Tweak styling Also: * Add blue badge theme * Fix and adjust TimeDisplay event formatting * Rename NewEventCard to EventCard * Make Badge inline-flex, add outline-white theme * Remove a tag color specification in themes * Fix merge: add back Block example in ComponentPage * Block: slightly decrease opacity of footer gradient and decrease header * Block: Improve gradients through easing * BlockImage: Use background-image instead of img element * Use Block components in EventCard * Block: Add white theme * Add text shadow to bottom text and show event category * Update location class name * biome * Show translated event category * Simplify fake events creation in ComponentPage * Set letter-spacing for BlockTitle * Update component page * Change "free" badge to green theme * Round edges more, sharpen on hover * Nesten utsolgt -> Få billetter igjen Matches samf3 * Switch out Buy ticket arrow icon * Create EventCardContainer. Allow more customization of EventCard/Block * Fix biome & stylelint * Don't show CTA if event is free
andsamfu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
andsamfu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
andsamfu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Logg inn" knappen kan heller stå som "intern" slik som det er på samfundet.no slik at det ikke blir misforståelser mellom intern, medlem og søker.
…ar, and updated text for internal login.
Nja, uenig. Denne renamingen i fea7e5c bør revertes. Samf4 sitt brukersystem skiller ikke på søkerprofil og vanlige brukere slik som samf3 gjør. Siden søkere skal også bruke det vanlige brukersystemet gir det ikke mening å endre knappen til "Intern". Behold "Logg inn". |
Da er jeg enig i å beholde det til "Logg inn". Trodde søkere og interne var to forskjellige brukere slik som på samf3. |
…rn", fixed breakpionts for navbar desktop to mobile
Removed commented TODOs regarding navbar styling.



Not quite the same navbar, but similar enough