Skip to content

[onert-micro/onert-micro] Refactoring and code cleanup for OMRuntimeShape#15154

Merged
chunseoklee merged 1 commit intoSamsung:masterfrom
monoamind:onert-micro-v2-refactoring1
Jun 9, 2025
Merged

[onert-micro/onert-micro] Refactoring and code cleanup for OMRuntimeShape#15154
chunseoklee merged 1 commit intoSamsung:masterfrom
monoamind:onert-micro-v2-refactoring1

Conversation

@monoamind
Copy link
Copy Markdown
Contributor

This provides initial refactoring of OMRuntimeShape.

For example:

  • C-array is replaced with std::array.
  • size_t is used for sizes/counts instead of signed integer.
  • Wherever possible, STL algorithms is used.
  • Functions like std::memcmp and std::memcpy are no longer used.

ONE-DCO-1.0-Signed-off-by: Denis Tarasenko monoamind@outlook.com

@chunseoklee
Copy link
Copy Markdown
Contributor

chunseoklee commented Apr 15, 2025

@monoamind @Torrero Could you confirm that this patch works in TizenRT build system ? AFAIK, some c++ feature is missing in TizenRT.

@Torrero
Copy link
Copy Markdown
Contributor

Torrero commented Apr 29, 2025

@monoamind @Torrero Could you confirm that this patch works in TizenRT build system ? AFAIK, some c++ feature is missing in TizenRT.

@chunseoklee, I tested this PR with TizenRT build system, it works ok.

Copy link
Copy Markdown
Contributor

@Torrero Torrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunseoklee
Copy link
Copy Markdown
Contributor

Please rebase this after merging #15286.

…hape

This provides initial refactoring of OMRuntimeShape.
For example:
- C-array is replaced with std::array.
- size_t is used for sizes/counts instead of signed integer.
- Wherever possible, STL algorithms is used.
- Functions like std::memcmp and std::memcpy are no  longer used.

ONE-DCO-1.0-Signed-off-by: Denis Tarasenko <monoamind@outlook.com>
@monoamind monoamind force-pushed the onert-micro-v2-refactoring1 branch from f5cb657 to 22ada34 Compare May 28, 2025 11:05
@monoamind
Copy link
Copy Markdown
Contributor Author

Please rebase this after merging #15286.

@chunseoklee
Done.

Copy link
Copy Markdown
Contributor

@SlavikMIPT SlavikMIPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunseoklee chunseoklee merged commit bc3b056 into Samsung:master Jun 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants