Skip to content

[onert] Check shape type of BroadcastTo#15179

Merged
glistening merged 1 commit intoSamsung:masterfrom
glistening:broadcast_check_more
Apr 17, 2025
Merged

[onert] Check shape type of BroadcastTo#15179
glistening merged 1 commit intoSamsung:masterfrom
glistening:broadcast_check_more

Conversation

@glistening
Copy link
Copy Markdown
Contributor

@glistening glistening commented Apr 17, 2025

It ensures shape's type is either int32 or int64.
It also adds a negative case.

ONE-DCO-1.0-Signed-off-by: Sanggyu Lee sg5.lee@samsung.com

$ Product/x86_64-linux.debug/out/unittest/nnfw_api_gtest
...
[ RUN      ] GenModelTest.neg_OneOp_BroadcastTo_InvalidShapeType
Error during model loading : OperationValidator failed at line 159
Failed model loading as expected.
[       OK ] GenModelTest.neg_OneOp_BroadcastTo_InvalidShapeType (0 ms)

Related: #15164 (comment)

@glistening glistening requested review from a team and seockho-kim April 17, 2025 03:46
Copy link
Copy Markdown
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It ensures shape's type is either int32 or int64.
It also adds a negative case.

ONE-DCO-1.0-Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
@glistening glistening force-pushed the broadcast_check_more branch from 72b2ad9 to cc5f7fe Compare April 17, 2025 06:05
@glistening glistening changed the title [ONERT] Check shape type of BroadcastTo [onert] Check shape type of BroadcastTo Apr 17, 2025
Copy link
Copy Markdown
Contributor

@seockho-kim seockho-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glistening glistening merged commit 32d385f into Samsung:master Apr 17, 2025
10 checks passed
@glistening glistening deleted the broadcast_check_more branch September 8, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants