Skip to content

[onert] Revisit BroadcastTo shape validation#15180

Merged
glistening merged 1 commit intoSamsung:masterfrom
glistening:broadcastto_shape_validate
Apr 17, 2025
Merged

[onert] Revisit BroadcastTo shape validation#15180
glistening merged 1 commit intoSamsung:masterfrom
glistening:broadcastto_shape_validate

Conversation

@glistening
Copy link
Copy Markdown
Contributor

@glistening glistening commented Apr 17, 2025

It updates shape validation code for BroadcastTo.

ONE-DCO-1.0-Signed-off-by: Sanggyu Lee sg5.lee@samsung.com

$ Product/x86_64-linux.debug/out/unittest/nnfw_api_gtest
...
[ RUN      ] GenModelTest.OneOp_BroadcastTo_1D_to_2D
[       OK ] GenModelTest.OneOp_BroadcastTo_1D_to_2D (0 ms)
[ RUN      ] GenModelTest.OneOp_BroadcastTo_2D_to_3D
[       OK ] GenModelTest.OneOp_BroadcastTo_2D_to_3D (0 ms)
[ RUN      ] GenModelTest.OneOp_BroadcastTo_3D_to_3D
[       OK ] GenModelTest.OneOp_BroadcastTo_3D_to_3D (0 ms)
[ RUN      ] GenModelTest.neg_OneOp_BroadcastTo_InputOutputDifferentType
Error during model loading : OperationValidator failed at line 157
Failed model loading as expected.
[       OK ] GenModelTest.neg_OneOp_BroadcastTo_InputOutputDifferentType (0 ms)
[ RUN      ] GenModelTest.neg_OneOp_BroadcastTo_1D_to_2D_InvalidShape
Error during model prepare : ShapeValidator failed at line 180
[       OK ] GenModelTest.neg_OneOp_BroadcastTo_1D_to_2D_InvalidShape (0 ms)
[ RUN      ] GenModelTest.neg_OneOp_BroadcastTo_2D_to_3D_InvalidShape
Error during model prepare : ShapeValidator failed at line 180
[       OK ] GenModelTest.neg_OneOp_BroadcastTo_2D_to_3D_InvalidShape (0 ms)
[ RUN      ] GenModelTest.neg_OneOp_BroadcastTo_3D_to_3D_InvalidShape
Error during model prepare : ShapeValidator failed at line 180
[       OK ] GenModelTest.neg_OneOp_BroadcastTo_3D_to_3D_InvalidShape (0 ms)

Related: #15164 (comment)

@glistening
[onert] Revisit BroadcastTo shape validation
7ceb669 
It updates shape validation code for BroadcastTo.

ONE-DCO-1.0-Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
@glistening glistening requested review from a team and seockho-kim April 17, 2025 06:03
seockho-kim
seockho-kim approved these changes Apr 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@seockho-kim seockho-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ragmani
ragmani reviewed Apr 17, 2025
View reviewed changes
Comment thread runtime/onert/core/src/compiler/ShapeValidator.cc
ragmani
ragmani approved these changes Apr 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glistening glistening merged commit 7774cc3 into Samsung:master Apr 17, 2025
10 checks passed
@glistening glistening deleted the broadcastto_shape_validate branch May 7, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ragmani ragmani ragmani approved these changes

@seockho-kim seockho-kim seockho-kim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@glistening @ragmani @seockho-kim