[circle-mlir/overlay] Check python version#15182
Closed
shs-park wants to merge 4 commits intoSamsung:masterfrom
Closed
[circle-mlir/overlay] Check python version#15182shs-park wants to merge 4 commits intoSamsung:masterfrom
shs-park wants to merge 4 commits intoSamsung:masterfrom
Conversation
This adds a minimum Python version constraint (3.10), in the `prepare-venv` script. ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
Contributor
Author
|
for issue #15181 |
ragmani
reviewed
Apr 17, 2025
ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com> Co-authored-by: ragmani <ragmani0216@gmail.com>
shs-park
force-pushed
the
circle-mlir/prepare-venv-python_ver
branch
from
8f7fb07 to
5798bea
Compare
ragmani
approved these changes
Apr 18, 2025
seanshpark
reviewed
Apr 20, 2025
| PYTHON_BIN=$(command -v python3) | ||
| fi | ||
|
|
||
| PYTHON_VER=$($PYTHON_BIN -c 'import sys; print(".".join(map(str, sys.version_info[:2])))') |
Contributor
There was a problem hiding this comment.
Can you plz check with find_package() ?
find_package(Python 3.10 EXACT COMPONENTS Interpreter QUIET)you can refer compiler/common-artifacts/CMakeLists.txt file
if(Python_VERSION VERSION_GREATER_EQUAL 3.12)
message(STATUS "...")
return()
endif()
if(Python_VERSION VERSION_LESS 3.8)
message(STATUS "...")
return()
endif()
Contributor
Author
There was a problem hiding this comment.
I'll create another PR to check the Python version through CMake.
Contributor
Author
|
Close this PR as another alternative PR #15193 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a minimum Python version constraint (3.10),
in the
prepare-venvscript.ONE-DCO-1.0-Signed-off-by: Seungho Henry Park shs.park@samsung.com