[onert/python] Introduce NNFW exception bindings#15363
Merged
hseok-oh merged 1 commit intoSamsung:masterfrom May 20, 2025
Merged
[onert/python] Introduce NNFW exception bindings#15363hseok-oh merged 1 commit intoSamsung:masterfrom
hseok-oh merged 1 commit intoSamsung:masterfrom
Conversation
This commit introduces NNFW exception bindings and comprehensive error handling. - Add `nnfw_exception_bindings.h` and `nnfw_exceptions.h` to define C++ exception types for NNFW errors - Bind all `NnfwError` subclasses into the Python module under a new exception submodule - Update `nnfw_api_wrapper` to replace `exit(1)` calls with throwing the corresponding NnfwError exceptions - Refactor `getLayout`, `getType` and `getStringType` to throw `NnfwError` on invalid inputs instead of exiting - In Python wrappers (`BaseSession`, `session`, and convenience functions), catch generic errors and rethrow them as `OnertError` with context - Ensure all C-API calls in Python raise `OnertError` on failure, improving robustness and traceback clarity ONE-DCO-1.0-Signed-off-by: ragmani <ragmani0216@gmail.com>
Contributor
Author
Contributor
Author
|
@Samsung/one_onert PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces NNFW exception bindings and comprehensive error handling.
nnfw_exception_bindings.handnnfw_exceptions.hto define C++ exception types for NNFW errorsNnfwErrorsubclasses into the Python module under a new exception submodulennfw_api_wrapperto replaceexit(1)calls with throwing the corresponding NnfwError exceptionsgetLayout,getTypeandgetStringTypeto throwNnfwErroron invalid inputs instead of exitingBaseSession,session, and convenience functions), catch generic errors and rethrow them asOnertErrorwith contextOnertErroron failure, improving robustness and traceback clarityONE-DCO-1.0-Signed-off-by: ragmani ragmani0216@gmail.com