[github] Fix test log path of run-onecc-build#15472
[github] Fix test log path of run-onecc-build#15472seanshpark merged 1 commit intoSamsung:masterfrom
Conversation
dc505d0 to
e69e56c
Compare
shs-park
left a comment
There was a problem hiding this comment.
I left a question, PTAL
=)
| path: | | ||
| ${{ env.NNCC_WORKSPACE }}/compiler/**/*.log | ||
| ${{ env.NNCC_INSTALL_PATH }}/test/**/*.log | ||
| ${NNCC_INSTALL_PATH}/test/**/*.log |
There was a problem hiding this comment.
AFAIK, single-brace variables (e.g., $VAR) can behave similarly to double-brace expressions (e.g., ${{ env.VAR }}) in some contexts, such as within bash shell scripts (run: blocks).
However, in GitHub Actions-specific contexts like path:, it's recommended to use double braces with the env. prefix (e.g., ${{ env.VAR }}) to ensure proper evaluation.
Did you perform to test whether this works correctly in the path: context?
I'm asking because I'm not entirely sure about its behavior there.
There was a problem hiding this comment.
| ${NNCC_INSTALL_PATH}/test/**/*.log | |
| ${{ env.NNCC_INSTALL_PATH }}/test/**/*.log |
There was a problem hiding this comment.
Did you perform to test whether this works correctly in the path: context?
https://github.com/Samsung/ONE/actions/runs/15289092665/job/43005157626?pr=15428
is slightly different but should work with ${NNCC_INSTALL_PATH}
as above name: Test(Release) step uses ${NNCC_INSTALL_PATH} which I've followed.
There was a problem hiding this comment.
I didn't check explictly about ${NNCC_INSTALL_PATH} is identical with ${{ env.NNCC_INSTALL_PATH }} but
I'd like to follow usage with above step.
There was a problem hiding this comment.
The above name: Test(Release) step uses ${NNCC_INSTALL_PATH} in the run: section, which executes a Bash script.
This might behave slightly differently when used in the path: field.
Anyway, I'm curious whether they behave the same.
Let’s find out once it’s landed. 😊
| path: | | ||
| ${{ env.NNCC_WORKSPACE }}/compiler/**/*.log | ||
| ${{ env.NNCC_INSTALL_PATH }}/test/**/*.log | ||
| ${NNCC_INSTALL_PATH}/test/**/*.log |
There was a problem hiding this comment.
The above name: Test(Release) step uses ${NNCC_INSTALL_PATH} in the run: section, which executes a Bash script.
This might behave slightly differently when used in the path: field.
Anyway, I'm curious whether they behave the same.
Let’s find out once it’s landed. 😊
|
I'll run some quick test with #15428 :) |
|
output looks which doesn't look correct |
|
with |
This will fix test log path of run-onecc-build workflow. ONE-DCO-1.0-Signed-off-by: SaeHie Park <saehie.park@gmail.com> Co-authored-by: Seungho Henry Park <shs.park@samsung.com>
e69e56c to
14ac60a
Compare
This will fix test log path of run-onecc-build workflow.
ONE-DCO-1.0-Signed-off-by: SaeHie Park saehie.park@gmail.com