Skip to content

[onert/python] Normalize file paths in setup.py#15881

Merged
hseok-oh merged 1 commit intoSamsung:masterfrom
hseok-oh:path_usagae_setup
Aug 8, 2025
Merged

[onert/python] Normalize file paths in setup.py#15881
hseok-oh merged 1 commit intoSamsung:masterfrom
hseok-oh:path_usagae_setup

Conversation

@hseok-oh
Copy link
Copy Markdown
Contributor

@hseok-oh hseok-oh commented Aug 7, 2025

This commit uses absolute path for DEFAULT_PRODUCT_DIR and uses os.path.normpath() for a more consistent path resolution.
It includes finding correct library path - lib/, lib32/, lib64/.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh hseok82.oh@samsung.com

@hseok-oh hseok-oh requested a review from a team August 7, 2025 02:02
@hseok-oh hseok-oh force-pushed the path_usagae_setup branch 3 times, most recently from 2d3128a to 09fcba1 Compare August 7, 2025 02:50
ragmani
ragmani previously approved these changes Aug 7, 2025
Copy link
Copy Markdown
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh marked this pull request as draft August 7, 2025 03:01
This commit uses absolute path for DEFAULT_PRODUCT_DIR and uses `os.path.normpath()` for a more consistent path resolution.
It includes finding correct library path - lib/, lib32/, lib64/.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
@hseok-oh hseok-oh force-pushed the path_usagae_setup branch from 09fcba1 to 7715abe Compare August 7, 2025 04:52
@hseok-oh hseok-oh marked this pull request as ready for review August 7, 2025 04:52
@hseok-oh hseok-oh requested a review from ragmani August 7, 2025 05:46
@hseok-oh hseok-oh added the PR/ready for review It is ready to review. Please review it. label Aug 7, 2025
Copy link
Copy Markdown
Contributor

@glistening glistening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit 92a69ad into Samsung:master Aug 8, 2025
11 checks passed
@hseok-oh hseok-oh deleted the path_usagae_setup branch August 8, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR/ready for review It is ready to review. Please review it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants