Skip to content

[infra] Install ccache to docker images#16226

Merged
hseok-oh merged 1 commit intoSamsung:masterfrom
hseok-oh:docker_ccache
Oct 24, 2025
Merged

[infra] Install ccache to docker images#16226
hseok-oh merged 1 commit intoSamsung:masterfrom
hseok-oh:docker_ccache

Conversation

@hseok-oh
Copy link
Copy Markdown
Contributor

@hseok-oh hseok-oh commented Oct 22, 2025

This commit installs ccache package and configure 1.5GB cache size in Docker images to improve build performance.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh hseok82.oh@samsung.com


Related issue: #16223

@seanshpark seanshpark requested a review from shs-park October 22, 2025 05:18
Copy link
Copy Markdown
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

seanshpark

This comment was marked as duplicate.

Copy link
Copy Markdown
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a question, PTAL
=)

Comment on lines +39 to +40
# Setup ccache max size: 1.5GB
RUN ccache -M 1536MB
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any specific reason for setting the ccache size to this value?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ccache's default size is 5GB, but github action cache's total size is 10GB. If we use default size 5GB, it's hard to maintain external source, overlay, and ccache in github action cache.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!
=)

shs-park
shs-park previously approved these changes Oct 22, 2025
@hseok-oh hseok-oh dismissed stale reviews from shs-park and seanshpark via 0f7ad82 October 22, 2025 08:54
@hseok-oh hseok-oh force-pushed the docker_ccache branch 5 times, most recently from e733b20 to 1af5609 Compare October 22, 2025 23:45
@hseok-oh hseok-oh marked this pull request as draft October 22, 2025 23:46
@hseok-oh hseok-oh force-pushed the docker_ccache branch 5 times, most recently from c9e9bdb to 8a18041 Compare October 23, 2025 07:01
@hseok-oh
Copy link
Copy Markdown
Contributor Author

Require #16230

This commit Installs ccache package and configure 1.5GB cache size in Docker images to improve build performance.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
@hseok-oh hseok-oh marked this pull request as ready for review October 24, 2025 00:48
@hseok-oh hseok-oh added the PR/ready for review It is ready to review. Please review it. label Oct 24, 2025
Copy link
Copy Markdown
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hseok-oh hseok-oh merged commit 57144d0 into Samsung:master Oct 24, 2025
9 checks passed
@hseok-oh hseok-oh deleted the docker_ccache branch October 24, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR/ready for review It is ready to review. Please review it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants