Skip to content

[onert] Make model-types optional in MANIFEST#16255

Merged
hseok-oh merged 1 commit intoSamsung:masterfrom
glistening:model_types_optional
Oct 30, 2025
Merged

[onert] Make model-types optional in MANIFEST#16255
hseok-oh merged 1 commit intoSamsung:masterfrom
glistening:model_types_optional

Conversation

@glistening
Copy link
Copy Markdown
Contributor

@glistening glistening commented Oct 29, 2025

It make model-types option by infering model-types from model file.
It uses the file extension for inference.

ONE-DCO-1.0-Signed-off-by: Sanggyu Lee sg5.lee@samsung.com

BEFORE

$ cat tinyllama/prefill/metadata/MANIFEST
{
  "models"      : [
      "emb.circle",
      "d0.circle",
      "d1.circle",
      "d2.circle",
      "d3.circle",
      "d4.circle",
      "d5.circle",
      "d6.circle",
      "d7.circle",
      ],
  "model-types" : [
     "circle",
     "circle",
     "circle",
     "circle",
     "circle",
     "circle",
     "circle",
     "circle",
     "circle",
     ],
  ...

AFTER

$ cat tinyllama/prefill/metadata/MANIFEST
{
  "models"      : [
      "emb.circle",
      "d0.circle",
      "d1.circle",
      "d2.circle",
      "d3.circle",
      "d4.circle",
      "d5.circle",
      "d6.circle",
      "d7.circle",
      ],
  ...

@glistening glistening requested a review from hseok-oh October 29, 2025 05:37
@glistening glistening force-pushed the model_types_optional branch 2 times, most recently from a4a0e57 to e1d1a38 Compare October 29, 2025 05:59
It make model-types option by infering model-types from model file.

ONE-DCO-1.0-Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
@glistening glistening force-pushed the model_types_optional branch from e1d1a38 to 0ea57ad Compare October 29, 2025 06:02
@glistening glistening added the PR/ready for review It is ready to review. Please review it. label Oct 29, 2025
@hseok-oh
Copy link
Copy Markdown
Contributor

Will we update nnpackage spec?

BTW, I cannot find documents about nnpackage versioning (only can find hint from nnpackage/examples/README.md)

@glistening
Copy link
Copy Markdown
Contributor Author

glistening commented Oct 29, 2025

https://github.com/Samsung/ONE/blob/master/nnpackage/spec/10_packaging_and_manifest.md

It has 3 commits:

https://github.com/Samsung/ONE/commits/master/nnpackage/spec/10_packaging_and_manifest.md

I will update the spec based on commit history and examples in another PR.

  1. specify model-types are optional

#### model-types
`model-types` is an array of strings that describes the type of each model in `models`.
It can have the values (case-sensitive) in following table.
| name | description |
|--------|------------------------|
| tflite | tensorflow lite schema |
| circle | nnpackage schema |
| tvn | trix-engine binary |

  1. add missing attributes (like model-connect, ...)

3. add version information (e.g. since 1.1.0)

It would be better to follow the way of circle_schema.fbs.

Copy link
Copy Markdown
Contributor

@hseok-oh hseok-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit 0d0a6e1 into Samsung:master Oct 30, 2025
10 checks passed
@glistening glistening deleted the model_types_optional branch October 31, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR/ready for review It is ready to review. Please review it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants