Skip to content

[onert] Remove redundant dl library linking in CMakeLists.txt #16284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hseok-oh merged 1 commit into from
Nov 18, 2025
+4 −4
Merged

[onert] Remove redundant dl library linking in CMakeLists.txt #16284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion runtime/onert/odc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ add_executable(${TEST_ONERT_ODC} ${TESTS})
target_link_libraries(${TEST_ONERT_ODC} onert_odc)
# Requires linking nnfw_coverage: check header coverage
target_link_libraries(${TEST_ONERT_ODC} nnfw_common nnfw_coverage)
target_link_libraries(${TEST_ONERT_ODC} gtest gtest_main dl Threads::Threads)
target_link_libraries(${TEST_ONERT_ODC} gtest gtest_main ${CMAKE_DL_LIBS} Threads::Threads)
target_include_directories(${TEST_ONERT_ODC} PRIVATE $<TARGET_PROPERTY:onert_odc,INCLUDE_DIRECTORIES>)

add_test(${TEST_ONERT_ODC} ${TEST_ONERT_ODC})
Expand Down
2 changes: 1 addition & 1 deletion runtime/tests/nnfw_api/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ target_include_directories(${RUNTIME_NNFW_API_TEST} PRIVATE ${RUNTIME_NNFW_API_T

target_link_libraries(${RUNTIME_NNFW_API_TEST} nnfw-dev jsoncpp)
target_link_libraries(${RUNTIME_NNFW_API_TEST} gtest gmock)
target_link_libraries(${RUNTIME_NNFW_API_TEST} Threads::Threads dl)
target_link_libraries(${RUNTIME_NNFW_API_TEST} Threads::Threads)
target_link_libraries(${RUNTIME_NNFW_API_TEST} circle_schema)
target_link_libraries(${RUNTIME_NNFW_API_TEST} nnfw_common)

Expand Down
2 changes: 1 addition & 1 deletion runtime/tests/tools/libs/tflite/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ set_target_properties(nnfw_lib_tflite PROPERTIES POSITION_INDEPENDENT_CODE ON)
target_include_directories(nnfw_lib_tflite PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/include)
target_link_libraries(nnfw_lib_tflite PUBLIC tensorflow-lite)
target_link_libraries(nnfw_lib_tflite PUBLIC nnfw_lib_misc nnfw_lib_benchmark)
target_link_libraries(nnfw_lib_tflite PRIVATE Threads::Threads dl)
target_link_libraries(nnfw_lib_tflite PRIVATE Threads::Threads)
target_link_libraries(nnfw_lib_tflite PRIVATE nnfw_common)

if(NOT ENABLE_TEST)
Expand Down
2 changes: 1 addition & 1 deletion runtime/tests/tools/onert_train/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ add_executable(${TEST_ONERT_TRAIN} ${ONERT_TRAIN_TEST_SRCS})

target_link_libraries(${TEST_ONERT_TRAIN} nnfw-dev)
target_link_libraries(${TEST_ONERT_TRAIN} nnfw_common)
target_link_libraries(${TEST_ONERT_TRAIN} gtest gtest_main dl Threads::Threads)
target_link_libraries(${TEST_ONERT_TRAIN} gtest gtest_main Threads::Threads)

add_test(${TEST_ONERT_TRAIN} ${TEST_ONERT_TRAIN})
install(TARGETS ${TEST_ONERT_TRAIN} DESTINATION unittest)