[circle-schema] Add MX dtype restrictions comment#16344
Merged
jinevening merged 1 commit intoSamsung:masterfrom Jan 14, 2026
Merged
[circle-schema] Add MX dtype restrictions comment#16344jinevening merged 1 commit intoSamsung:masterfrom
jinevening merged 1 commit intoSamsung:masterfrom
Conversation
jinevening
reviewed
Jan 14, 2026
Comment on lines
+93
to
+94
| // - Model does not have MX dtype's parameters (block size, exponent scale, etc). | ||
| // Backend should define and use internally if needed |
Collaborator
There was a problem hiding this comment.
MX type is quite flexible, but some types (FP4, INT8) have pre-determined parameters according to OCP spec. The ones in the circle schema (MXFP4 and MXINT8) follow OCP spec.
PTAL Concrete MX-compliant Formats in https://www.opencompute.org/documents/ocp-microscaling-formats-mx-v1-0-spec-final-pdf
Collaborator
There was a problem hiding this comment.
Better to write "These MX dtypes follow MX-compliant Formats in OCP spec"?
Contributor
Author
There was a problem hiding this comment.
I've updated comment
This commit adds comprehensive comments documenting current restrictions for MX dtypes (MXFP4, MXINT8) in the circle schema. ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
hseok-oh
force-pushed
the
mx_type_comment
branch
from
8a5f42c to
66c0f32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds comprehensive comments documenting current restrictions for MX dtypes (MXFP4, MXINT8) in the circle schema.
ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]