Skip to content

DRAFT circle-mlir: Introduce pass for Sign operation#16380

Closed
shs-park wants to merge 38 commits intoSamsung:masterfrom
shs-park:circle-mlir/draft-introduce-sign-op
Closed

DRAFT circle-mlir: Introduce pass for Sign operation#16380
shs-park wants to merge 38 commits intoSamsung:masterfrom
shs-park:circle-mlir/draft-introduce-sign-op

Conversation

@shs-park
Copy link
Copy Markdown
Contributor

This is to introduce a pass for ONNX::Sign operation in circle-mlir.

It simply fixes a typo in comment.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
This introduces the test models for Range operation.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
This activates the test models for Range operation.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
This introduces the Sign pass for the onnx2circle.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
@shs-park shs-park added PR/NO TEST Tell CI to not run test PR/NO MERGE Please don't merge. I'm still working on this :) DRAFT A draft issue or PR for sharing one's current working status and discussion. labels Feb 10, 2026
Copy link
Copy Markdown
Contributor Author

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shs-park and others added 22 commits February 12, 2026 19:33
This simply fixes a typo in comment.

Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
This introduces test models for the Range operation.
The tests will be activated once support for the Range pass is completed.

Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
This introduces the dialect and its corresponding pass for the Range operation.

Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
This adds support for the Sign operation in tflchef.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
This activates the model tests for the newly intrudoced Range pass.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
This adds support for the Sign operation in tflite2circle.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
* [luci/lang] Introduce Sign operation

This adds support for the Sign operation in luci/lang.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
* [luci/import] Introduce Sign operation

This introduces the Sign operation to luci/import.

Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
This updates the version of `onnx2circle` to `0.4.2`.
It includes the changes for ReduceSumSquare and Range operations.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
This updates the changelog for onnx2circle_0.4.2~202602230830.

It is auto-generated PR from github workflow.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
…msung#16379)

These changes ensure that pipeline resources are properly released even
in error scenarios or when the pipeline was not fully initialized,
preventing potential resource leaks.

ONE-DCO-1.0-Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
This introduces the Sign operation to luci/export.

Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
This introduces the Sign operation to luci/service.

Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
It adds the Conv2d test model with padding and group set.

ONE-DCO-1.0-Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
This introduces the Sign operation to luci/partition.

Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
* [luci-interpreter] Introduce Sign operation

This introduces the Sign operation to luci-interpreter.

Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
This creates a test TFLite recipe for the Sign operation.

Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
This fixes the `pub-circle-int-launchpad.yml` workflow to use `mio-circle`
instead of `mio-circle08`.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
This activates the `luci` and `luci-valu-test` for Sign operation.

Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
This updates the changelog for circle-interpreter_1.30.1~202602260919.

It is auto-generated PR from github workflow.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
- Added IndexError enum and bounds checks in GatherND, Slice, Pad, and dimension product calculation to prevent out-of-bounds accesses and negative indices.

- Fixes security vulnerabilities related to index validation.

ONE-DCO-1.0-Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
This commit adds verification step to ensure loaded models have
matching input/output counts with the pipeline configuration.

ONE-DCO-1.0-Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
hseok-oh and others added 9 commits February 27, 2026 08:57
This commit adds `.git-blame-ignore-revs` file to ignore blame history such as reformatting commit.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
After inserting padding on the input tensor, the intype variable
is now updated to reflect the type of the padded input.

ONE-DCO-1.0-Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
This commit refactores copyright-check script to accept files as command-line arguments instead of searching for files internally.
The pre-commit hook now handles file pattern matching and exclusion logic for C/C++ source files (*.c, *.cc, *.cpp, *.cl, *.h, *.hpp), filtering out 3rd-party code.
It will reduce commit creation time by removing pre-commit's duplicated copyright check.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
This commit moves copyright-check script from infra/command/ to infra/git-hooks/ and rename with .sh extension.
And it removes deprecated format command and git commit hook script.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
…6414)

It enables the former Conv2d model test with padding and group
set as modification is applied to the Conv2d Pass.

ONE-DCO-1.0-Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
This commit updates pre-commit configuration to enable shebang checking.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
Trying to compile generated tests on Ubuntu 25.10 results in a
compilation error due to name clash between test case namespace
and function from the standard library:

ONE-DCO-1.0-Signed-off-by: Arkadiusz Bokowy <a.bokowy@samsung.com>
)

Replace multi-step NPU request workflow with single blocking API call.
This change removes the complex threading mechanism used to handle
submitNPU_request timeout and thread-safety issues.

ONE-DCO-1.0-Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
This updates the changelog for onnx2circle_0.4.2~202603040257.

It is auto-generated PR from github workflow.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
shs-park added 3 commits March 6, 2026 09:23
This introduces the Sign operation to the dialect.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
This introduces the test models for Sign operation.
It will be activated after the operation is implemented.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
…park/ONE into circle-mlir/draft-introduce-sign-op

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
@shs-park
Copy link
Copy Markdown
Contributor Author

shs-park commented Mar 9, 2026

done!

@shs-park shs-park closed this Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DRAFT A draft issue or PR for sharing one's current working status and discussion. PR/NO MERGE Please don't merge. I'm still working on this :) PR/NO TEST Tell CI to not run test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants