Skip to content

[luci-interpreter] Introduce Sign operation#16403

Merged
mhs4670go merged 5 commits intoSamsung:masterfrom
shs-park:compiler/luci-interpreter-sign-op
Feb 25, 2026
Merged

[luci-interpreter] Introduce Sign operation#16403
mhs4670go merged 5 commits intoSamsung:masterfrom
shs-park:compiler/luci-interpreter-sign-op

Conversation

@shs-park
Copy link
Copy Markdown
Contributor

This introduces the Sign operation to luci-interpreter.

This introduces the Sign operation to luci-interpreter.

Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
@shs-park shs-park self-assigned this Feb 24, 2026
Update license comment.
Copy link
Copy Markdown
Contributor Author

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shs-park shs-park marked this pull request as draft February 24, 2026 09:10
Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
@shs-park shs-park marked this pull request as ready for review February 24, 2026 11:02
@shs-park shs-park requested a review from a team February 24, 2026 11:03
@shs-park shs-park added PR/ready for review It is ready to review. Please review it. area/compiler labels Feb 24, 2026
return ElementsAreArray(matchers);
}

Matcher<std::vector<double>> DoubleArrayNear(const std::vector<double> &values,
Copy link
Copy Markdown
Contributor Author

@shs-park shs-park Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DoubleArrayNear function is introduced to test FLOAT64 value test in TEST(SignTest, Float64) above.

Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
Copy link
Copy Markdown
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@batcheu batcheu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@hseok-oh hseok-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhs4670go mhs4670go merged commit f4bbc7b into Samsung:master Feb 25, 2026
6 checks passed
@shs-park shs-park deleted the compiler/luci-interpreter-sign-op branch February 25, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/compiler PR/ready for review It is ready to review. Please review it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants