[compiler] Fix exception throw in the deprecated code#16484
Open
arkq wants to merge 1 commit intoSamsung:masterfrom
Open
[compiler] Fix exception throw in the deprecated code#16484arkq wants to merge 1 commit intoSamsung:masterfrom
arkq wants to merge 1 commit intoSamsung:masterfrom
Conversation
This commit fixes a typo causing the exception not being thrown. ONE-DCO-1.0-Signed-off-by: Arkadiusz Bokowy <a.bokowy@samsung.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the deprecated mir2loco transformer where an exception object was constructed but never thrown, allowing unsupported constant data types to proceed silently.
Changes:
- Replace
std::runtime_error(...)construction withthrow std::runtime_error(...)in theConstantOpdtype switch default case.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a typo causing the exception not being thrown.
It is the last PR in a series to fix all occurrences of missing
throwwhen runtime exception should be thrown:git grep ' std::runtime_error'.