Skip to content

Do not create redundant Pad with MaxPool#163

Merged
mhs4670go merged 1 commit into
Samsung:mainfrom
mhs4670go:sup3
Jun 19, 2025
Merged

Do not create redundant Pad with MaxPool#163
mhs4670go merged 1 commit into
Samsung:mainfrom
mhs4670go:sup3

Conversation

@mhs4670go

@mhs4670go mhs4670go commented Jun 19, 2025

Copy link
Copy Markdown
Contributor

This commit doesn't create redundant Pad with MaxPool.
image

TICO-DCO-1.0-Signed-off-by: seongwoo mhs4670go@naver.com

@mhs4670go mhs4670go requested a review from a team June 19, 2025 04:22

@dayo09 dayo09 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glistening glistening left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix typo in commit title.

redundnat → redundant

Also, what about:

  • Do not create redundant Pad with MaxPool
  • Don't create redundant Pad with MaxPool

This commit doesn't create redundant Pad with MaxPool.

TICO-DCO-1.0-Signed-off-by: seongwoo <mhs4670go@naver.com>
@mhs4670go mhs4670go requested a review from glistening June 19, 2025 05:02
@mhs4670go mhs4670go changed the title Doesn't create redundnat Pad with MaxPool Do not create redundant Pad with MaxPool Jun 19, 2025

@glistening glistening left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhs4670go mhs4670go merged commit 9beff14 into Samsung:main Jun 19, 2025
5 checks passed
@mhs4670go mhs4670go deleted the sup3 branch June 20, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants