Support Add, Relu in InsertQuantizeOpOnDtypeMismatch#166
Merged
Conversation
This adds Add, Relu in InsertQuantizeOpOnDtypeMismatch. TICO-DCO-1.0-Signed-off-by: Hyukjin Jeong <hj1.jeong@samsung.com>
jinevening
commented
Jun 20, 2025
| min_ = u8_scale * (-u8_zerop) | ||
|
|
||
| abs_max = max([max_, min_], key=abs) | ||
| abs_max = abs(max([max_, min_], key=abs)) |
Contributor
Author
There was a problem hiding this comment.
This line fixes a bug. Without this change, scale can be a negative value.
dayo09
reviewed
Jun 20, 2025
|
|
||
| if qparam_dtype(x) == "int16" and qparam_dtype(node) == "uint8": | ||
| quantize = _insert_quantize_op_after(node) | ||
|
|
Contributor
There was a problem hiding this comment.
Is it okay without checking qparam_dtype(y)? What if one of x and y get folded in another pass and dtype gets differ?
Contributor
Author
There was a problem hiding this comment.
Sounds reasonable. I will add a check for that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Add, Relu in InsertQuantizeOpOnDtypeMismatch.
TICO-DCO-1.0-Signed-off-by: Hyukjin Jeong hj1.jeong@samsung.com
Related to: #165