[passes] Consider multiple DQ case#169
Merged
Merged
Conversation
This commit considers multiple DQ case in SimpleAdd. TICO-DCO-1.0-Signed-off-by: seongwoo <mhs4670go@naver.com>
dayo09
reviewed
Jun 20, 2025
Comment on lines
+53
to
+55
| op ─ Q ─┬─ DQ0 op(meta[QPARAM]) | ||
| ├─ DQ1 (each DQ* folded, Q dropped when orphaned) | ||
| └─ DQ2 |
Contributor
There was a problem hiding this comment.
Could you elaborate this case? How those three different DQs be folded to one op?
Contributor
Author
There was a problem hiding this comment.
All DQs have same qparam. This pattern is from pt2e quantization of torch.
jinevening
reviewed
Jun 23, 2025
| # ─────────────────────────────────────────── | ||
| else: | ||
| op_qparam: QuantParam = op.meta[QPARAM_KEY] | ||
| existing_qp: QuantParam = op.meta[QPARAM_KEY] |
Contributor
There was a problem hiding this comment.
(optional) To me, op_qparam looks clearer. It's aligned with the comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit considers multiple DQ case in SimpleAdd.
The case happens with pt2 quantization.
TICO-DCO-1.0-Signed-off-by: seongwoo mhs4670go@naver.com