[NUI] Refactoring LinearLayout #6963
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaehyun0cho
requested review from
Seoyeon2Kim,
dongsug-song,
everLEEst,
hinohie,
hyunjushin,
rabbitfor and
taehyub
as code owners
jaehyun0cho
force-pushed
the
RefactoringLinearLayout_API12
branch
2 times, most recently
from
085da5c to
1704c05
Compare
jaehyun0cho
force-pushed
the
RefactoringLinearLayout_API12
branch
from
1704c05 to
7aa6e19
Compare
jaehyun0cho
force-pushed
the
RefactoringLinearLayout_API12
branch
2 times, most recently
from
f8725b6 to
7cf1462
Compare
LinearLayout does not exceed its constraints. LinearLayout respects its minimum and maximum size. LinearLayout removes unused its private method. LinearLayout is fixed to layout reverse order in RTL mode. LinearLayout is fixed to calculate Padding.Start and End for RTL mode.
LinearLayout is fixed to support negative CellPadding. If LinearLayout items are overlapped by negative CellPadding, then LinearLayout size becomes smaller to bound its items. e.g. LinearLayout has Wrap size, Item size is 100, CellPadding is -50. If negative CellPadding's absolute value is bigger than item size, then items may be displayed outside of LinearLayout. In this case, LinearLayout size bounds its items but items may not be inside the LinearLayout. e.g. LinearLayout has Wrap size, Item size is 100, CellPadding is -200.
jaehyun0cho
force-pushed
the
RefactoringLinearLayout_API12
branch
from
7cf1462 to
e8b556e
Compare
Contributor
|
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinearLayout does not exceed its constraints.
LinearLayout respects its minimum and maximum size.
LinearLayout removes unused its private method.
LinearLayout supports negative CellPadding.
Description of Change
API Changes