Skip to content

Refactor Libraryimport/phase 2 #7560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoonghyunCho merged 9 commits into from
Apr 14, 2026
Merged

Refactor Libraryimport/phase 2 #7560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3341d86
Migrate DllImport to LibraryImport in medium-risk modules (Phase 2)
Apr 9, 2026
49e3bd4
[Fix] Phase 2: Fix build errors in Tizen.Applications.Common
Apr 10, 2026
d53d7d2
[Fix] Phase 2: Deep clean - remove 26 unnecessary StringMarshalling, …
Apr 10, 2026
a46ceb6
[Fix] Phase 2: Revert 16 files that overlap with Phase 1 to main
Apr 10, 2026
3a0f52e
[Fix] Phase 2: Revert 68 files belonging to Phase 3/4 to main
Apr 10, 2026
fc4fe29
[Fix] Phase 2: Revert incorrect MarshalAs(U1) on DllImport bool params
Apr 10, 2026
198215e
[Fix] Phase 2: Revert delegate bool MarshalAs changes (separate PR sc…
Apr 10, 2026
f818fd9
[Fix] Phase 2: Restore DllImport for WebAuthn MakeCredential/GetAsser…
Apr 10, 2026
a9b1c34
[Fix] Phase 2: Exclude TCT-failing modules from PR
Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 50 additions & 51 deletions src/Tizen.Applications.Alarm/Interop/Interop.Alarm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

using System;
using System.Runtime.InteropServices;
using System.Runtime.InteropServices.Marshalling;

using Tizen.Internals;
using Tizen.Applications;
Expand All @@ -43,80 +42,80 @@ internal struct DateTime
internal IntPtr tm_zone;
};

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_schedule_after_delay")]
internal static partial int CreateAlarmAfterDelay(SafeAppControlHandle appControl, int delay, int period, out int alarmId);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_schedule_after_delay")]
internal static extern int CreateAlarmAfterDelay(SafeAppControlHandle appControl, int delay, int period, out int alarmId);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_schedule_once_after_delay")]
internal static partial int CreateAlarmOnceAfterDelay(SafeAppControlHandle appControl, int delay, out int alarmId);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_schedule_once_after_delay")]
internal static extern int CreateAlarmOnceAfterDelay(SafeAppControlHandle appControl, int delay, out int alarmId);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_schedule_once_at_date")]
internal static partial int CreateAlarmOnceAtDate(SafeAppControlHandle appControl, ref DateTime date, out int alarmId);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_schedule_once_at_date")]
internal static extern int CreateAlarmOnceAtDate(SafeAppControlHandle appControl, ref DateTime date, out int alarmId);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_schedule_with_recurrence_week_flag")]
internal static partial int CreateAlarmRecurWeek(SafeAppControlHandle appControl, ref DateTime date, int week, out int alarmId);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_schedule_with_recurrence_week_flag")]
internal static extern int CreateAlarmRecurWeek(SafeAppControlHandle appControl, ref DateTime date, int week, out int alarmId);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_schedule_service_with_recurrence_seconds")]
internal static partial int CreateAlarmRecurForService(SafeAppControlHandle appControl, ref DateTime date, int period, out int alarmId);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_schedule_service_with_recurrence_seconds")]
internal static extern int CreateAlarmRecurForService(SafeAppControlHandle appControl, ref DateTime date, int period, out int alarmId);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_schedule_service_once_after_delay")]
internal static partial int CreateAlarmOnceAfterDelayForService(SafeAppControlHandle appControl, int delay, out int alarmId);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_schedule_service_once_after_delay")]
internal static extern int CreateAlarmOnceAfterDelayForService(SafeAppControlHandle appControl, int delay, out int alarmId);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_schedule_service_once_at_date")]
internal static partial int CreateAlarmOnceAtDateForService(SafeAppControlHandle appControl, ref DateTime date, out int alarmId);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_schedule_service_once_at_date")]
internal static extern int CreateAlarmOnceAtDateForService(SafeAppControlHandle appControl, ref DateTime date, out int alarmId);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_get_scheduled_recurrence_week_flag")]
internal static partial int GetAlarmWeekFlag(int alarmId, out int weekFlag);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_get_scheduled_recurrence_week_flag")]
internal static extern int GetAlarmWeekFlag(int alarmId, out int weekFlag);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_cancel")]
internal static partial int CancelAlarm(int alarmId);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_cancel")]
internal static extern int CancelAlarm(int alarmId);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_cancel_all")]
internal static partial int CancelAllAlarms();
[DllImport(Libraries.Alarm, EntryPoint = "alarm_cancel_all")]
internal static extern int CancelAllAlarms();

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_get_scheduled_date")]
internal static partial int GetAlarmScheduledDate(int alarmId, out DateTime date);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_get_scheduled_date")]
internal static extern int GetAlarmScheduledDate(int alarmId, out DateTime date);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_get_current_time")]
internal static partial int GetCurrentTime(out DateTime date);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_get_current_time")]
internal static extern int GetCurrentTime(out DateTime date);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_get_app_control")]
internal static partial int GetAlarmAppControl(int alarmId, out SafeAppControlHandle control);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_get_app_control")]
internal static extern int GetAlarmAppControl(int alarmId, out SafeAppControlHandle control);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_get_scheduled_period")]
internal static partial int GetAlarmScheduledPeriod(int alarmId, out int period);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_get_scheduled_period")]
internal static extern int GetAlarmScheduledPeriod(int alarmId, out int period);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_set_global")]
internal static partial int SetAlarmGlobalFlag(int alarmId, [MarshalAs(UnmanagedType.U1)] bool global);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_set_global")]
internal static extern int SetAlarmGlobalFlag(int alarmId, bool global);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_get_global")]
internal static partial int GetAlarmGlobalFlag(int alarmId, [MarshalAs(UnmanagedType.U1)] out bool global);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_get_global")]
internal static extern int GetAlarmGlobalFlag(int alarmId, out bool global);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_foreach_registered_alarm")]
internal static partial int GetAllRegisteredAlarms(RegisteredAlarmCallback callback, IntPtr userData);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_foreach_registered_alarm")]
internal static extern int GetAllRegisteredAlarms(RegisteredAlarmCallback callback, IntPtr userData);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_schedule_noti_once_at_date")]
internal static partial AlarmError CreateAlarmNotiOnceAtDate(NotificationSafeHandle noti, ref DateTime date, out int alarmId);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_schedule_noti_once_at_date")]
internal static extern AlarmError CreateAlarmNotiOnceAtDate(NotificationSafeHandle noti, ref DateTime date, out int alarmId);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_schedule_noti_after_delay")]
internal static partial AlarmError CreateAlarmNotiAfterDelay(NotificationSafeHandle noti, int delay, int period, out int alarmId);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_schedule_noti_after_delay")]
internal static extern AlarmError CreateAlarmNotiAfterDelay(NotificationSafeHandle noti, int delay, int period, out int alarmId);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_schedule_noti_once_after_delay")]
internal static partial AlarmError CreateAlarmNotiOnceAfterDelay(NotificationSafeHandle noti, int delay, out int alarmId);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_schedule_noti_once_after_delay")]
internal static extern AlarmError CreateAlarmNotiOnceAfterDelay(NotificationSafeHandle noti, int delay, out int alarmId);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_schedule_noti_with_recurrence_week_flag")]
internal static partial AlarmError CreateAlarmNotiRecurWeek(NotificationSafeHandle noti, ref DateTime date, int week, out int alarmId);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_schedule_noti_with_recurrence_week_flag")]
internal static extern AlarmError CreateAlarmNotiRecurWeek(NotificationSafeHandle noti, ref DateTime date, int week, out int alarmId);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_update_delay")]
internal static partial AlarmError UpdateDelay(int alarmId, int delay);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_update_delay")]
internal static extern AlarmError UpdateDelay(int alarmId, int delay);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_update_date")]
internal static partial AlarmError UpdateDate(int alarmId, ref DateTime date);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_update_date")]
internal static extern AlarmError UpdateDate(int alarmId, ref DateTime date);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_update_period")]
internal static partial AlarmError UpdatePeriod(int alarmId, int period);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_update_period")]
internal static extern AlarmError UpdatePeriod(int alarmId, int period);

[LibraryImport(Libraries.Alarm, EntryPoint = "alarm_update_week_flag")]
internal static partial AlarmError UpdateWeekFlag(int alarmId, int week);
[DllImport(Libraries.Alarm, EntryPoint = "alarm_update_week_flag")]
internal static extern AlarmError UpdateWeekFlag(int alarmId, int week);

//callback
[UnmanagedFunctionPointer(CallingConvention.Cdecl)]
Expand Down
63 changes: 31 additions & 32 deletions src/Tizen.Applications.AttachPanel/Interop/Interop.AttachPanel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using System;
using System.Runtime.InteropServices;
using System.Runtime.InteropServices.Marshalling;
using Tizen.Applications;

/// <summary>
Expand Down Expand Up @@ -31,49 +30,49 @@ internal enum ErrorCode : int
[UnmanagedFunctionPointer(CallingConvention.Cdecl)]
internal delegate void AttachPanelResultCallback(IntPtr attachPanel, int category, IntPtr result, int resultCode, IntPtr userData);

[LibraryImport(Libraries.AttachPanel, EntryPoint = "attach_panel_create")]
internal static partial ErrorCode CreateAttachPanel(IntPtr conform, out IntPtr attach_panel);
[DllImport(Libraries.AttachPanel, EntryPoint = "attach_panel_create")]
internal static extern ErrorCode CreateAttachPanel(IntPtr conform, out IntPtr attach_panel);

[LibraryImport(Libraries.AttachPanel, EntryPoint = "attach_panel_destroy")]
internal static partial ErrorCode DestroyAttachPanel(IntPtr attach_panel);
[DllImport(Libraries.AttachPanel, EntryPoint = "attach_panel_destroy")]
internal static extern ErrorCode DestroyAttachPanel(IntPtr attach_panel);

[LibraryImport(Libraries.AttachPanel, EntryPoint = "attach_panel_add_content_category")]
internal static partial ErrorCode AddCategory(IntPtr attach_panel, int content_category, IntPtr extraData);
[DllImport(Libraries.AttachPanel, EntryPoint = "attach_panel_add_content_category")]
internal static extern ErrorCode AddCategory(IntPtr attach_panel, int content_category, IntPtr extraData);

[LibraryImport(Libraries.AttachPanel, EntryPoint = "attach_panel_remove_content_category")]
internal static partial ErrorCode RemoveCategory(IntPtr attach_panel, int content_category);
[DllImport(Libraries.AttachPanel, EntryPoint = "attach_panel_remove_content_category")]
internal static extern ErrorCode RemoveCategory(IntPtr attach_panel, int content_category);

[LibraryImport(Libraries.AttachPanel, EntryPoint = "attach_panel_set_extra_data")]
internal static partial ErrorCode SetExtraData(IntPtr attach_panel, int content_category, IntPtr extraData);
[DllImport(Libraries.AttachPanel, EntryPoint = "attach_panel_set_extra_data")]
internal static extern ErrorCode SetExtraData(IntPtr attach_panel, int content_category, IntPtr extraData);

[LibraryImport(Libraries.AttachPanel, EntryPoint = "attach_panel_set_result_cb")]
internal static partial ErrorCode SetResultCb(IntPtr attach_panel, AttachPanelResultCallback callback, IntPtr userData);
[DllImport(Libraries.AttachPanel, EntryPoint = "attach_panel_set_result_cb")]
internal static extern ErrorCode SetResultCb(IntPtr attach_panel, AttachPanelResultCallback callback, IntPtr userData);

[LibraryImport(Libraries.AttachPanel, EntryPoint = "attach_panel_unset_result_cb")]
internal static partial ErrorCode UnsetResultCb(IntPtr attach_panel);
[DllImport(Libraries.AttachPanel, EntryPoint = "attach_panel_unset_result_cb")]
internal static extern ErrorCode UnsetResultCb(IntPtr attach_panel);

[LibraryImport(Libraries.AttachPanel, EntryPoint = "attach_panel_set_event_cb")]
internal static partial ErrorCode SetEventCb(IntPtr attach_panel, AttachPanelEventCallback callback, IntPtr userData);
[DllImport(Libraries.AttachPanel, EntryPoint = "attach_panel_set_event_cb")]
internal static extern ErrorCode SetEventCb(IntPtr attach_panel, AttachPanelEventCallback callback, IntPtr userData);

[LibraryImport(Libraries.AttachPanel, EntryPoint = "attach_panel_unset_event_cb")]
internal static partial ErrorCode UnsetEventCb(IntPtr attach_panel);
[DllImport(Libraries.AttachPanel, EntryPoint = "attach_panel_unset_event_cb")]
internal static extern ErrorCode UnsetEventCb(IntPtr attach_panel);

[LibraryImport(Libraries.AttachPanel, EntryPoint = "attach_panel_show")]
internal static partial ErrorCode Show(IntPtr attach_panel);
[DllImport(Libraries.AttachPanel, EntryPoint = "attach_panel_show")]
internal static extern ErrorCode Show(IntPtr attach_panel);

[LibraryImport(Libraries.AttachPanel, EntryPoint = "attach_panel_show_without_animation")]
internal static partial ErrorCode ShowWithoutAnimation(IntPtr attach_panel);
[DllImport(Libraries.AttachPanel, EntryPoint = "attach_panel_show_without_animation")]
internal static extern ErrorCode ShowWithoutAnimation(IntPtr attach_panel);

[LibraryImport(Libraries.AttachPanel, EntryPoint = "attach_panel_hide")]
internal static partial ErrorCode Hide(IntPtr attach_panel);
[DllImport(Libraries.AttachPanel, EntryPoint = "attach_panel_hide")]
internal static extern ErrorCode Hide(IntPtr attach_panel);

[LibraryImport(Libraries.AttachPanel, EntryPoint = "attach_panel_hide_without_animation")]
internal static partial ErrorCode HideWithoutAnimation(IntPtr attach_panel);
[DllImport(Libraries.AttachPanel, EntryPoint = "attach_panel_hide_without_animation")]
internal static extern ErrorCode HideWithoutAnimation(IntPtr attach_panel);

[LibraryImport(Libraries.AttachPanel, EntryPoint = "attach_panel_get_visibility")]
internal static partial ErrorCode GetVisibility(IntPtr attach_panel, out int visible);
[DllImport(Libraries.AttachPanel, EntryPoint = "attach_panel_get_visibility")]
internal static extern ErrorCode GetVisibility(IntPtr attach_panel, out int visible);

[LibraryImport(Libraries.AttachPanel, EntryPoint = "attach_panel_get_state")]
internal static partial ErrorCode GetState(IntPtr attach_panel, out int state);
[DllImport(Libraries.AttachPanel, EntryPoint = "attach_panel_get_state")]
internal static extern ErrorCode GetState(IntPtr attach_panel, out int state);
}
}
}
37 changes: 18 additions & 19 deletions src/Tizen.Applications.Badge/Interop/Interop.Badge.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

using System;
using System.Runtime.InteropServices;
using System.Runtime.InteropServices.Marshalling;
using Tizen.Applications;

internal static partial class Interop
Expand All @@ -36,31 +35,31 @@ internal enum Action : uint

internal delegate void ChangedCallback(Action action, string appId, uint count, IntPtr userData);

[LibraryImport(Libraries.Badge, EntryPoint = "badge_add", StringMarshalling = StringMarshalling.Utf8)]
internal static partial BadgeError Add(string appId);
[DllImport(Libraries.Badge, EntryPoint = "badge_add")]
internal static extern BadgeError Add(string appId);

[LibraryImport(Libraries.Badge, EntryPoint = "badge_remove", StringMarshalling = StringMarshalling.Utf8)]
internal static partial BadgeError Remove(string appId);
[DllImport(Libraries.Badge, EntryPoint = "badge_remove")]
internal static extern BadgeError Remove(string appId);

[LibraryImport(Libraries.Badge, EntryPoint = "badge_set_count", StringMarshalling = StringMarshalling.Utf8)]
internal static partial BadgeError SetCount(string appId, uint count);
[DllImport(Libraries.Badge, EntryPoint = "badge_set_count")]
internal static extern BadgeError SetCount(string appId, uint count);

[LibraryImport(Libraries.Badge, EntryPoint = "badge_get_count", StringMarshalling = StringMarshalling.Utf8)]
internal static partial BadgeError GetCount(string appId, out uint count);
[DllImport(Libraries.Badge, EntryPoint = "badge_get_count")]
internal static extern BadgeError GetCount(string appId, out uint count);

[LibraryImport(Libraries.Badge, EntryPoint = "badge_set_display", StringMarshalling = StringMarshalling.Utf8)]
internal static partial BadgeError SetDisplay(string appId, uint isDisplay);
[DllImport(Libraries.Badge, EntryPoint = "badge_set_display")]
internal static extern BadgeError SetDisplay(string appId, uint isDisplay);

[LibraryImport(Libraries.Badge, EntryPoint = "badge_get_display", StringMarshalling = StringMarshalling.Utf8)]
internal static partial BadgeError GetDisplay(string appId, out uint isDisplay);
[DllImport(Libraries.Badge, EntryPoint = "badge_get_display")]
internal static extern BadgeError GetDisplay(string appId, out uint isDisplay);

[LibraryImport(Libraries.Badge, EntryPoint = "badge_foreach")]
internal static partial BadgeError Foreach(ForeachCallback callback, IntPtr userData);
[DllImport(Libraries.Badge, EntryPoint = "badge_foreach")]
internal static extern BadgeError Foreach(ForeachCallback callback, IntPtr userData);

[LibraryImport(Libraries.Badge, EntryPoint = "badge_register_changed_cb")]
internal static partial BadgeError SetChangedCallback(ChangedCallback callback, IntPtr userData);
[DllImport(Libraries.Badge, EntryPoint = "badge_register_changed_cb")]
internal static extern BadgeError SetChangedCallback(ChangedCallback callback, IntPtr userData);

[LibraryImport(Libraries.Badge, EntryPoint = "badge_unregister_changed_cb")]
internal static partial BadgeError UnsetChangedCallback(ChangedCallback callback);
[DllImport(Libraries.Badge, EntryPoint = "badge_unregister_changed_cb")]
internal static extern BadgeError UnsetChangedCallback(ChangedCallback callback);
}
}
3 changes: 3 additions & 0 deletions src/Tizen.Applications.Cion/Interop/Interop.Cion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,6 @@ internal enum ErrorCode : int
}
}
}



Loading
Loading