[AI Task] Remove Log.Info from Sensor.cs property accessors#7594
Open
JoonghyunCho wants to merge 1 commit into
Open
[AI Task] Remove Log.Info from Sensor.cs property accessors#7594JoonghyunCho wants to merge 1 commit into
JoonghyunCho wants to merge 1 commit into
Conversation
Convert read-only properties to expression-bodied form and remove diagnostic Log.Info calls from getters/setters. Keeps Log.Info calls in state-change methods (Start/Stop) and all Log.Error paths intact. 19 Log.Info calls removed; ~94 lines reduced. Public API preserved.
Member
Author
|
|
Member
Author
|
🤖 [AI Review] Reviewed — no findings. Scope checked:
No 🔴 critical issues, no 🟡 suggestions to flag. Automated review — final merge decision rests with human reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove diagnostic
Log.Infocalls fromSensor.csproperty getters/setters and convert simple accessors to expression-bodied form. Avoids per-access string allocations anddlogsyscalls on hot-path property reads (e.g.,Timestamp,IsSensing,Interval).Changes
src/Tizen.Sensor/Tizen.Sensor/Sensor.csLog.Infocalls removed from property accessors (Name,Vendor,MinValue,MaxValue,Resolution,MinInterval,FifoCount,MaxBatchCount,Interval,MaxBatchLatency,PausePolicy,TimeSpan,Timestamp,IsSensing).Log.InfoinStart()/Stop()and allLog.Errorpaths are preserved.Mode
Refactoring
Verification
dotnet build src/Tizen.Sensor/Tizen.Sensor.csproj, 0 errors; pre-existing CS1570 warning inBatchSensor.csunrelated).dlogsyscalls in property-read hot paths.API Compatibility
Fixes #7573