Skip to content

Remove widget application docs#7652

Open
kdk3776 wants to merge 1 commit into
Samsung:tizen-docs-pagesfrom
kdk3776:tizen-docs-pages
Open

Remove widget application docs#7652
kdk3776 wants to merge 1 commit into
Samsung:tizen-docs-pagesfrom
kdk3776:tizen-docs-pages

Conversation

@kdk3776
Copy link
Copy Markdown
Contributor

@kdk3776 kdk3776 commented May 19, 2026

Description of Change

API Changes

  • ACR: TCSACR-635

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several generated HTML documentation files for the WidgetApplication and WidgetBase classes in the API14 directory. The reviewer feedback highlights that the pull request description is currently empty and should be completed. Additionally, the reviewer suggests removing the corresponding source files (such as .yml or .md) to prevent the documentation from being regenerated and recommends updating the Table of Contents (toc.html) to ensure there are no broken links in the navigation sidebar.

@@ -1,287 +0,0 @@
<!DOCTYPE html>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pull request description is empty and contains placeholder text. It is recommended to provide a brief summary of the changes to help reviewers and maintain a clear project history.

<meta name="viewport" content="width=device-width">
<meta name="title" content="Class WidgetApplication
">
<meta name="generator" content="docfx ">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

If these HTML files are generated using DocFX, the corresponding source files (e.g., .yml or .md files) should also be removed from the repository to prevent them from being regenerated in future builds.

<link rel="stylesheet" href="../../styles/tizen.css">
<link href="https://fonts.googleapis.com/css?family=Roboto" rel="stylesheet">

<meta property="docfx:tocrel" content="toc.html">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The removal of these documentation files should be accompanied by an update to the Table of Contents (toc.html) to remove the corresponding entries. Otherwise, the documentation site will contain broken links in the navigation sidebar.

@kdk3776 kdk3776 requested review from JoonghyunCho, hjhun and wiertel May 19, 2026 08:39
@JoonghyunCho
Copy link
Copy Markdown
Member

You may need to update gh-pages branch

@JoonghyunCho
Copy link
Copy Markdown
Member

🤖 [AI Review]

Reviewed — no findings.

Scope checked:

  • All 3 deleted files belong to the same deprecated API surface: Tizen.Applications.WidgetApplication, Tizen.Applications.WidgetBase, and Tizen.Applications.WidgetBase.WidgetDestroyType — consistent with the stated ACR (TCSACR-635).
  • Verified change targets the tizen-docs-pages branch (docs-only) with no .cs source modifications — appropriate scope for a doc removal PR.
  • Cross-checked the published gh-pages branch: the three HTML files no longer exist under API14/api/, but the navigation artifacts (API14/api/toc.html ~150 KB, index-API14.json ~648 KB) may still hold dangling references — regeneration of those is the path to keep navigation consistent.
  • No remaining sibling files for the Widget application surface were left orphaned in the diff (related, non-deprecated entries such as Tizen.Applications.WidgetControl* and Tizen.Applications.WidgetLifecycleEventArgs* are untouched and remain present on tizen-docs-pages).

No 🔴 critical issues, no 🟡 suggestions to flag.


Automated review — final merge decision rests with human reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants