[NUI][TCSACR-652] Make deprecated class Tizen.NUI.Adaptor as internal#7673
Conversation
Description of Change
[NUI] Make deprecated class Tizen.NUI.Adaptor as internal
Note : Some friend assembled project use Adaptor.Instance so we cannot remove it. Just keep it as internal.
API Changes
ACR: TCSACR-652
Removed:
class Tizen.NUI.Adaptor
static Adaptor Instance { get; }
void FeedWheelEvent(Wheel);
void FeedKeyEvent(Key);
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request changes the visibility of the Adaptor class and its members (including Instance, FeedWheelEvent, and FeedKeyEvent) from public to internal, and removes their obsolete attributes. The feedback suggests improving the grammatical phrasing in the newly added XML documentation remarks for better readability and standard terminology.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| /// <remarks> | ||
| /// Deprecated at API8, Become internal at API14. | ||
| /// </remarks> |
There was a problem hiding this comment.
The grammatical phrasing "Deprecated at API8, Become internal at API14" can be improved for better readability and standard terminology. It is more idiomatic to use "in" instead of "at" for API versions, and "became" (past tense) instead of "Become".
/// <remarks>
/// Deprecated in API8, became internal in API14.
/// </remarks>
Public API ChangedPlease follow the ACR process for the changed API below. Added: 0, Removed: 4, Changed: 0Removed- /// <since_tizen>4</since_tizen
- [Obsolete]
- Tizen.NUI.Adaptor
- /// <since_tizen>4</since_tizen
- [Obsolete]
- Tizen.NUI.Adaptor Tizen.NUI.Adaptor::Instance()
- /// <since_tizen>4</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.Adaptor::FeedKeyEvent(Tizen.NUI.Key)
- /// <since_tizen>4</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.Adaptor::FeedWheelEvent(Tizen.NUI.Wheel)
Internal API ChangedAdded: 0, Removed: 1, Changed: 0Removed- /// <since_tizen>none</since_tizen
- [Obsolete]
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.Adaptor::ReleaseSwigCPtr(System.Runtime.InteropServices.HandleRef)
|
3 participants
No description provided.